-
Notifications
You must be signed in to change notification settings - Fork 30
Avoid events for smooth piecewise #2840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
==========================================
- Coverage 79.62% 79.05% -0.57%
==========================================
Files 358 358
Lines 23033 23077 +44
Branches 1581 1582 +1
==========================================
- Hits 18339 18243 -96
- Misses 4683 4823 +140
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Test. Related to AMICI-dev#2840.
Test. Related to #2840.
|
Comment on why this hasn't been merged yet: I currently don't really trust the C1 continuity check as assignments etc are not flattened out. This might imply that we could inadvertently miss discontinuities, but maybe it's all fine as we can assume continuity of the respective terms. Haven't thought about it enough. |
Summary
Testing
pre-commit run --files python/sdist/amici/import_utils.py python/tests/test_heavisides.py
pytest python/tests/test_heavisides.py::test_parse_piecewise_c1_no_heaviside python/tests/test_heavisides.py::test_parse_piecewise_discontinuous_to_heaviside python/tests/test_heavisides.py::test_parse_piecewise_c1_constant_zero -q
fixes #2049
https://chatgpt.com/codex/tasks/task_b_685d399bee14832b899b26d9136e2fda