Skip to content

Conversation

FFroehlich
Copy link
Member

Summary

  • ensure test_presimulation actually runs presimulation
  • verify gradients are nonzero
  • add more observables to presimulation fixture

Testing

  • pre-commit run --files python/tests/test_sbml_import.py python/tests/conftest.py
  • pytest python/tests/test_sbml_import.py::test_presimulation -q

https://chatgpt.com/codex/tasks/task_b_685d25fb7768832b840af6f1e4437acb

@FFroehlich FFroehlich requested a review from a team as a code owner June 26, 2025 15:14
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.18%. Comparing base (82d53b4) to head (6e53c63).
Report is 8 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (82d53b4) and HEAD (6e53c63). Click for more details.

HEAD has 71 uploads less than BASE
Flag BASE (82d53b4) HEAD (6e53c63)
petab 2 1
python 38 1
cpp_python 15 0
cpp 15 0
sbmlsuite-jax 3 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2837      +/-   ##
==========================================
- Coverage   80.97%   74.18%   -6.80%     
==========================================
  Files         328      329       +1     
  Lines       22405    21695     -710     
  Branches     1515     1505      -10     
==========================================
- Hits        18142    16094    -2048     
- Misses       4252     4970     +718     
- Partials       11      631     +620     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 39.25% <ø> (-0.07%) ⬇️
python 71.82% <ø> (-3.34%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tests/conftest.py 41.37% <ø> (ø)

... and 62 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@FFroehlich FFroehlich removed the request for review from a team June 27, 2025 23:13
@FFroehlich FFroehlich marked this pull request as draft June 27, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant