Skip to content

Conversation

coleramos425
Copy link
Collaborator

Must fix typo in flag name, otherwise you'll break GT e.g.
image

Signed-off-by: coleramos425 <[email protected]>
@coleramos425 coleramos425 requested a review from mawad-amd June 3, 2025 19:09
@mawad-amd
Copy link
Member

Sorry, this breaking change was intentional to match the naming convention. Please change the rocHPG action. I will change the rest.

@coleramos425
Copy link
Collaborator Author

Technically, nothing needs to change in the rocHPCG repo. The yaml attribute being named top_n with an underscore causes no issues. Rather it's the

image

To clarify, is it the yaml attribute you will expect me to rename? e.g. top_n -> top-n

@mawad-amd
Copy link
Member

Oh I see. Yes, your YAML is correct. Maestro uses top_n and this command is the Maestro one.
GT uses top-n as excepted here https://github.com/AMDResearch/maestro/blob/muhaawad/formulas/src/core/application.py#L78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants