Integrate Tracediff into Perf Report Comparison #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spandoesai
force-pushed
the
spanmore/add_tracediff_to_report_comparison
branch
from
5fd3dc5 to
c384dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Perf Report comparison script currently diffs two Excel reports. However, this limits deeper comparison of two traces (ex. comparing ops that have different names in two traces or visualizing some ops which are only seen in one of the traces).
TraceDiff aims to solve these issues by comparing the trace trees at a structural level using dynamic programming algorithms. Added a flag that allows users to choose TraceDiff to generate the op level comparison sheet.
[Closes #311]