[WIP] Methods to aggregate figures of merit #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current run script methods do not aggregate figure of merit performance data as a final summary. The following changes are intended as an example for how this could be achieved. **This PR should be marked as WIP.** Final run methods should review the applicability of these approaches across other architectures, and make use of "standardized" language to ensure that FOM values appear consistently across implementations.
jaredAMD
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
|
Thanks for the comments! The log output already includes both per-iteration values and running averages (from log_avg_skip_iterations to the current iteration，and reset every log_avg_reset_interval iterations). For example: throughput per GPU (TFLOP/s/GPU): 520.9/520.3
tokens per GPU (tokens/s/GPU): 8994.2/8983.3Here the first number is the current iteration, and the second number is the average so far. The values in the last iteration already represent the metrics for the entire training run, so that line can be taken as the final summary. 
|
Xiaoming-AMD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current run script methods do not aggregate figure of merit performance data as a final summary. The following changes are intended as an example for how this could be achieved.
This PR should be marked as WIP.
Final run methods should review the applicability of these approaches across other architectures, and make use of "standardized" language to ensure that FOM values appear consistently across implementations.