Skip to content

Conversation

niyucao
Copy link

@niyucao niyucao commented Sep 15, 2025

Added a folder in OmniXAS called tutorial_omnixas. It has all the same files as omnixas but with the necessary data added as well as a tutorial notebook that walks through using OmniXAS step by step. The entire folder is created to make the referenced file paths in the notebook easy instead of having to reference the original omnixas.

@xhqu1981 xhqu1981 requested review from deyulu and xhqu1981 September 23, 2025 17:05
@xhqu1981
Copy link
Collaborator

Thanks Nina! This is a nice tutorial. I find no red flags and like it. One minor comment: currently, you notebook is not running in sequential order. Could you please test whether sequential run works by "Run All Cells"? After you you upload a notebook with sequential run, I will approve the pull request.

@niyucao
Copy link
Author

niyucao commented Sep 25, 2025

Thank you Xiaohui! I've just adjusted the notebook so it runs sequentially. Let me know if it works on your end!

Copy link
Collaborator

@xhqu1981 xhqu1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deyulu It looks good to me. Please review and merge.

@deyulu
Copy link
Contributor

deyulu commented Oct 1, 2025

@niyucao What is the difference between folders Cu and FEFF/Cu? Are they duplicates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants