Skip to content

Conversation

DannyLiCom
Copy link
Collaborator

Fixes / Features

  • Added functionality to delete conflicting parameters and overwrite duplicate ones, ensuring user-defined settings take precedence.

Testing / Documentation

Can be tested when creating a cluster using XPK.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

…gement, and added functionalities to remove duplicate parameters and overwrite existing ones.
@DannyLiCom
Copy link
Collaborator Author

@SujeethJinesh

Copy link
Collaborator

@SujeethJinesh SujeethJinesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Danny!

I think if this function works well, it could be good to expand to using this functionality in other commands in XPK in subsequent PRs. But that should be decided by XPK folks.

And I'd suggest adding some more context to the description that this is necessary for any default flags that are overridden by the user (e.g. the networking flags and such).

@pawloch00
Copy link
Collaborator

Description should be better. Is this change only for extra args passed by string?

@DannyLiCom
Copy link
Collaborator Author

@pawloch00 Please review it again. Thanks!

Copy link
Collaborator

@SujeethJinesh SujeethJinesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good to me, but still a few lingering questions.

Copy link
Collaborator

@SujeethJinesh SujeethJinesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think things look largely good minus the few leftover comments. Thanks!

@DannyLiCom
Copy link
Collaborator Author

@SujeethJinesh Maybe the xpk owner needs to verify?

@DannyLiCom
Copy link
Collaborator Author

Requires xpk owner verification. @pawloch00 or @Obliviour

@pawloch00
Copy link
Collaborator

Please merge develop and fix pipeline

@pawloch00
Copy link
Collaborator

@DannyLiCom you have been invited as collaborator. Please switch to xpk branch instead of fork and recreate your PR. Sorry for the inconvenience

@DannyLiCom DannyLiCom enabled auto-merge July 11, 2025 10:05
@pawloch00
Copy link
Collaborator

I think its duplicate of #527, closing @DannyLiCom

@pawloch00 pawloch00 closed this Jul 18, 2025
auto-merge was automatically disabled July 18, 2025 10:10

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants