Skip to content

Better use of gyro in re-zeroing process #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

TheFlameFish
Copy link
Contributor

Frontend Features:

  • Driver can press back / select button on controller to re-zero odometry yaw based on gyro output. This allows for substantially faster re-zeroing if we lose field-centric.

Backend:

  • Configure omnimount so we don't have to invert our gyro output (done on physical robot)
  • When doing a full yaw re-zero (start / menu button), re-zero the gyro as well. This means our gyro output should be accurate and always zeroed independently of overall odometry. This will be useful if we use constrained solve pnp for our vision algorithm.

Todo before ready for merge:

  • Test on Dory
  • Configure OmniMount on Nautilus and modify code accordingly (don't invert gyro output)
  • Test on Nautilus

Copy link
Member

@Ace5tar Ace5tar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual code looks fine to me, I would just be sure that drivers want it to be start for NavX re-zero and back for field-centric only, not vice versa in case

@Ace5tar Ace5tar self-requested a review March 31, 2025 23:01
Ace5tar
Ace5tar previously approved these changes Mar 31, 2025
Copy link
Member

@Ace5tar Ace5tar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual code looks fine to me, I would just be sure that drivers want it to be start for NavX re-zero and back for field-centric only, not vice versa in case

Previous review was meant to be an approval, i misclicked

@TheFlameFish TheFlameFish marked this pull request as ready for review April 3, 2025 02:59
@TheFlameFish
Copy link
Contributor Author

Nautilus gyro no worky. Fix on this branch I hope maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants