-
Notifications
You must be signed in to change notification settings - Fork 0
Add a pre-industrial nitrogen example #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested with https://code.metoffice.gov.uk/trac/roses-u/browser/d/q/8/1/9/nitrogen-ozone?rev=337274 |
|
This file still seems to be using the input4MIPS units of kg m-2 s-1 rather than ESM 1.6 g m-2 day-1 |
|
OK. I will change the units to g m-2 day-1 |
|
Looking at the published STASH codes for NITROGEN DEPOSITION, there is a code Examining the file Examining https://forum.access-hive.org.au/t/proposed-changes-to-variable-names-in-um-netcdf-conversion/4599 reveals This makes sense, since STASH section 3 refers to "boundary layer and surface". I will change the STASH code to |
|
Tested with https://code.metoffice.gov.uk/trac/roses-u/browser/d/q/8/1/9/nitrogen-ozone?rev=337274 |
|
The units used by CABLE are different to those used by MOSES/JULES so we have to ignore what the STASHmaster file says. The STASH code in the ancillary file has to be Fix for um2nc ACCESS-NRI/um2nc-standalone#208 |
|
I spoke to Spencer. See https://github.com/ACCESS-NRI/access-esm1.6-configs/blob/dev-preindustrial%2Bconcentrations/atmosphere/prefix.PRESM_A lines 711-715: This agrees with the output of |
|
Output is in |
|
Looks good now. See #93 (comment) I was thrown for a while by the 1850 differences between 1-1 and 1-2. |
atteggiani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Paul. Looks good.
I left a couple small comments.
The example notebook reads in the CMIP7 nitrogen forcing datasets as Iris cubes, adds the cubes, and then creates an ancillary from the resulting cube, except that is does not save the ancil file.
The notebook cannot use the
/g/data/access/ngm/modules/antsmodules because they use separate Singularity containers for Python.