E as editinacme #703
Open
E as editinacme #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference lazygit merged a change that can use |
|
Is your sed command portable? |
|
Good call, I'll rework it |
|
Please don't consider me a Reviewer. |
rakoo
force-pushed
the
E-as-editinacme
branch
3 times, most recently
from
136c790 to
48f44f7
Compare
|
requires #708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the expected case where the files ends up being edited in acme, do as editinacme does: when the window of the file is closed it means we're done. No need for an extra binary in another repository. The old logic is kept as a backup.
In addition, allow line numbers to be specified in the input (as in
E file:13) and still work with both logics.