Changed way ETA is calcualted. #555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the ETA function in seed recovery so its calculated by MATH, not COUNTING, which can take hours/days. This way the user doesnt have to use --no-eta, and lose their ability to have an ETA, but doesnt have to waste time counting the number of permutations.
|
This is very useful for basic tokenlists, but this doesn't take arguments, wildcards or anchors into consideration. (So should check if any of these are present and fall-back to manual generation method for these) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the ETA function in seed recovery so its calculated by MATH, not COUNTING, which can take hours/days. This way the user doesnt have to use --no-eta, and lose their ability to have an ETA, but doesnt have to waste time counting the number of permutations.