Skip to content

Conversation

luisnquin
Copy link
Contributor

Overview

This change removes the dependency on flake-utils and replaces it with nix-systems.
It introduces a forAllSystems helper based on nixpkgs.lib.genAttrs to generate development shells for all supported systems.
The overall structure of the flake remains the same, but the dependency graph is simplified and more explicit.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  1. Run nix develop on any supported system.
  2. Confirm that a development shell is created with the Go toolchain (go, gopls).
  3. Validate that nixosModules and hmModules can still be imported as before.

Changelog

Replaced flake-utils with nix-systems and refactored flake outputs to generate development shells for all supported systems.

@luisnquin
Copy link
Contributor Author

CI is just failing on the old nixpkgs pin, not from this change.

@mrjones2014
Copy link
Member

Hi, thanks for your contribution!

If you rebase on main your CI should pass, some long-needed maintenance surrounding the nix stuff has finally merged.

@mrjones2014
Copy link
Member

I'm happy to approve once that's done, this change looks good.

@luisnquin luisnquin force-pushed the refactor/replace-flake-utils-with-systems branch from b1814e0 to 6e92afd Compare August 28, 2025 04:03
@luisnquin
Copy link
Contributor Author

This looks ready. :)

Copy link
Member

@mrjones2014 mrjones2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and cuts down a bit of bloat in the dep tree! Thanks!

@mrjones2014
Copy link
Member

Maybe @volodymyrZotov can provide a second approval?

@mrjones2014 mrjones2014 merged commit 0e02f8a into 1Password:main Aug 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants