-
Notifications
You must be signed in to change notification settings - Fork 41
fix: upgrade @radix-ui to latest #3537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@aldenquimby is attempting to deploy a commit to the 100mslive Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@aldenquimby do verify all the modals and dropdowns are working properly if not already done. You can use the above vercel preview link as well with any of your room code to test |
|
@raviteja83 yes they are working on the Vercel preview: And my team is already running this in our fork in production, no issues yet |
|
@aldenquimby FYI, when you click on layout in the settings modal, it crashes, might be due to some radix component. most likely slider. |
|
@raviteja83 I think the problem might be how the example/prebuilt is built and deployed to Vercel?
When the prebuilt is shipped to Vercel, does it automatically pull in the local version of cd packages/roomkit-react
yarn link
cd ../../examples/prebuilt-react-integration
yarn link "@100mslive/roomkit-react"So that the local roomkit-react is used instead of the deployed |
|
@aldenquimby yes, it does use the local build only from the branch |
|
@raviteja83 could you send me build command used by Vercel, so I can try to replicate the issue? Thank you |
|
@aldenquimby do |
|
@raviteja83
And the full install command, so that the local version of the packages is used by the example: What is a good next step for me to debug? Do you have any other ideas for how I could repro? Could you invite me to your Vercel project so I can see the entire config you are using? |
|
check the react version dependencies in your implementation and here/ There might be a mismatch. Let me also try to repro locally, i think it did happen when I was upgrading the deps in a different PR |




Description
Implementation note, gotchas, related work and Future TODOs (optional)
release notes here
only 2 packages had major version upgrades - select and label
@radix-ui/react-selectlooks safe:@radix-ui/react-labellooks safe:Pre-launch Checklist
Merging: