Skip to content

Conversation

@aldenquimby
Copy link
Contributor

Description

Implementation note, gotchas, related work and Future TODOs (optional)

  • release notes here

  • only 2 packages had major version upgrades - select and label

  • @radix-ui/react-select looks safe:
    image

  • @radix-ui/react-label looks safe:
    image

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Merging:

  • Squash merge to dev
  • Merge commit to publish-alpha and main

@vercel
Copy link

vercel bot commented Sep 9, 2025

@aldenquimby is attempting to deploy a commit to the 100mslive Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dashboard-app Ready Ready Preview Comment Sep 10, 2025 11:40am

@raviteja83
Copy link
Collaborator

@aldenquimby do verify all the modals and dropdowns are working properly if not already done. You can use the above vercel preview link as well with any of your room code to test

@aldenquimby
Copy link
Contributor Author

@raviteja83 yes they are working on the Vercel preview:
image

And my team is already running this in our fork in production, no issues yet

@raviteja83
Copy link
Collaborator

raviteja83 commented Sep 11, 2025

@aldenquimby FYI, when you click on layout in the settings modal, it crashes, might be due to some radix component. most likely slider.

@aldenquimby
Copy link
Contributor Author

@raviteja83 I think the problem might be how the example/prebuilt is built and deployed to Vercel?

  1. Running dev from the example locally, there are no issues with the slider:
image
  1. The embedded version in my product is using these radix versions already and not seeing the problem:
image

When the prebuilt is shipped to Vercel, does it automatically pull in the local version of roomkit-react? Locally I use these steps:

cd packages/roomkit-react
yarn link
cd ../../examples/prebuilt-react-integration
yarn link "@100mslive/roomkit-react"

So that the local roomkit-react is used instead of the deployed 0.3.38 version

@raviteja83
Copy link
Collaborator

@aldenquimby yes, it does use the local build only from the branch

@aldenquimby
Copy link
Contributor Author

@raviteja83 could you send me build command used by Vercel, so I can try to replicate the issue? Thank you

@raviteja83
Copy link
Collaborator

@aldenquimby do yarn build at root level, then do yarn start in prebuilt-react-integration

@aldenquimby
Copy link
Contributor Author

@raviteja83 yarn start does not exist for me in prebuilt. If I do yarn dev instead, I am unable to reproduce the issue locally. I am also unable to reproduce the issue when building this branch and embedding it in my main app. And I created a new Vercel project and shipped example/prebuilt to it and cannot reproduce any issues. Here is the config I used in Vercel:

image

And the full install command, so that the local version of the packages is used by the example:

yarn install && cd packages/roomkit-react && yarn link && cd ../../examples/prebuilt-react-integration && yarn link "@100mslive/roomkit-react"  && cd ../..

What is a good next step for me to debug? Do you have any other ideas for how I could repro? Could you invite me to your Vercel project so I can see the entire config you are using?

@raviteja83
Copy link
Collaborator

check the react version dependencies in your implementation and here/ There might be a mismatch. Let me also try to repro locally, i think it did happen when I was upgrading the deps in a different PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants