feat(socks): enforce semaphore to limit connection count #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server was failing with a "Too many open files" error when handling a large number of concurrent connections. This was because each new connection would spawn a new task that would open a new socket, quickly exhausting the available file descriptors. This commit fixes the issue by introducing a `tokio::sync::Semaphore` to limit the number of concurrently running connection handler tasks. The maximum number of concurrent tasks is controlled by the `--concurrent` command-line argument. This prevents the server from opening an excessive number of sockets simultaneously, resolving the error and improving stability under heavy load.
0x676e67
changed the title
|
Can you also add limits for the HTTP/HTTPS servers? It would be best to complete it within the same PR so that this issue won’t need to be handled again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.