-
-
Couldn't load subscription status.
- Fork 73
feat(client): adapt overriding domain name resolution address #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements DNS domain name resolution address overriding functionality, allowing users to specify custom IP addresses for domain names that bypass normal DNS resolution.
- Added a new
resolve_to_addrsparameter to the Client constructor for overriding DNS resolution - Implemented extractor logic to handle Python dictionary mappings from domain names to IP addresses
- Created test coverage and example usage demonstrating the DNS override feature
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/dns_test.py | Adds test case verifying DNS override functionality by expecting connection failure to a local IP |
| src/extractor.rs | Implements extractor for converting Python dict to DNS resolution mappings |
| src/client/mod.rs | Integrates DNS override parameter into client builder and reorganizes method implementations |
| python/rnet/init.pyi | Updates type definitions to include the new resolve_to_addrs parameter |
| python/examples/dns_override.py | Provides example usage of the DNS override feature |
| README.md | Minor reordering of feature list items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
close: #352