Merge branch 'hotfix/156'

Close #156

Author: weierophinney

src/Generator/ClassGenerator.php

@@ -28,6 +28,7 @@
 use function ltrim;
 use function sprintf;
 use function str_replace;
+use function strpos;
 use function strrpos;
 use function strstr;
 use function strtolower;
@@ -288,7 +289,7 @@ public function __construct(
      */
     public function setName($name)
     {
-        if (strstr($name, '\\')) {
+        if (false !== strpos($name, '\\')) {
             $namespace = substr($name, 0, strrpos($name, '\\'));
             $name      = substr($name, strrpos($name, '\\') + 1);
             $this->setNamespaceName($namespace);

src/Generator/DocBlock/TagManager.php

@@ -15,6 +15,7 @@
 
 use function method_exists;
 use function substr;
+use function strpos;
 use function ucfirst;
 
 /**
@@ -57,12 +58,12 @@ public function createTagFromReflection(ReflectionTagInterface $reflectionTag)
         // transport any properties via accessors and mutators from reflection to codegen object
         $reflectionClass = new \ReflectionClass($reflectionTag);
         foreach ($reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
-            if (substr($method->getName(), 0, 3) == 'get') {
+            if (0 === strpos($method->getName(), 'get')) {
                 $propertyName = substr($method->getName(), 3);
                 if (method_exists($newTag, 'set' . $propertyName)) {
                     $newTag->{'set' . $propertyName}($reflectionTag->{'get' . $propertyName}());
                 }
-            } elseif (substr($method->getName(), 0, 2) == 'is') {
+            } elseif (0 === strpos($method->getName(), 'is')) {
                 $propertyName = ucfirst($method->getName());
                 if (method_exists($newTag, 'set' . $propertyName)) {
                     $newTag->{'set' . $propertyName}($reflectionTag->{$method->getName()}());

src/Scanner/ConstantScanner.php

@@ -19,6 +19,7 @@
 use function reset;
 use function strtolower;
 use function substr;
+use function strpos;
 use function var_export;
 
 class ConstantScanner implements ScannerInterface
@@ -217,7 +218,7 @@ protected function scan()
                 case T_LNUMBER:
                     $string = is_string($token) ? $token : $tokenContent;
 
-                    if (substr($string, 0, 1) === '"' || substr($string, 0, 1) === "'") {
+                    if (0 === strpos($string, '"') || 0 === strpos($string, "'")) {
                         $this->value = substr($string, 1, -1); // Remove quotes
                     } else {
                         $this->value = $string;

src/Scanner/PropertyScanner.php

@@ -316,7 +316,7 @@ protected function scan()
             $this->valueType = self::T_INTEGER;
         } elseif (0 === strpos($value, 'array') || 0 === strpos($value, '[')) {
             $this->valueType = self::T_ARRAY;
-        } elseif (substr($value, 0, 1) === '"' || substr($value, 0, 1) === "'") {
+        } elseif (0 === strpos($value, '"') || 0 === strpos($value, "'")) {
             $value = substr($value, 1, -1); // Remove quotes
             $this->valueType = self::T_STRING;
         }