Add Integer type validation to Literal::Flags.define #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that all flag values are Integers when defining flags to prevent runtime errors caused by non-Integer values in bit operations.
Motivation for the changes
The primary motivation for this change is to prevent potential runtime errors.
For instance, when a class inheriting from
Literal::Flags8
was defined as follows:I got an error with the following. This is because
nil
was expanded to an empty String, leading to a syntax error.In another case, the following class was defined and then initialized with
Example.new(a: true)
.This resulted in a TypeError.
Based on these two examples, it is evident that the
Literal::Flags.define
method should only accept integer values for its flags. For this reason, I have proposed the changes to enforce this validation.