Merge pull request #189 from xmartlabs/ios-error-handling

[Chore] iOS error handling

Author: Joaguirrem

example/app/(app)/_layout.tsx

@@ -0,0 +1,22 @@
+import 'react-native-reanimated'
+
+import { Stack } from 'expo-router'
+
+import { useListenLocalStorage } from '@/common/localStorage'
+
+export default function () {
+  const [accessToken] = useListenLocalStorage('accessToken')
+
+  const isLoggedIn = Boolean(accessToken)
+
+  return (
+    <Stack screenOptions={{ headerShown: false }}>
+      <Stack.Protected guard={isLoggedIn}>
+        <Stack.Screen name="index" />
+      </Stack.Protected>
+      <Stack.Protected guard={!isLoggedIn}>
+        <Stack.Screen name="login" />
+      </Stack.Protected>
+    </Stack>
+  )
+}

example/app/(app)/home.tsx renamed to example/app/(app)/index.tsx

@@ -6,6 +6,7 @@ import { useRouter } from 'expo-router'
 import { Fragment, useEffect, useState } from 'react'
 import { Alert, Dimensions, Image, StyleSheet } from 'react-native'
 
+import { LineError } from '@/common/errors'
 import {
   removeLocalStorageItem,
   setLocalStorageItem,
@@ -15,8 +16,11 @@ import { Bullet } from '@/components/Bullet'
 import { Button } from '@/components/Button'
 import { ThemedView } from '@/components/ThemedView'
 
-function handleError(error: Error) {
-  return Alert.alert(strings.errorTitle, error?.message ?? strings.errorMessage)
+function handleError(error: LineError) {
+  const userInfo = JSON.parse(error.userInfo?.message ?? '')
+  const title = strings.errorTitle + userInfo.statusCode
+  const message = userInfo.message ?? strings.errorMessage
+  return Alert.alert(title, message)
 }
 
 export default function () {
@@ -41,7 +45,7 @@ export default function () {
     return Line.logout()
       .then(() => {
         removeLocalStorageItem('accessToken')
-        router.replace('/login')
+        router.replace('/')
       })
       .finally(() => setLoading(false))
   }
@@ -96,8 +100,8 @@ export default function () {
 
 const strings = {
   accessToken: 'Access Token',
-  errorMessage: 'Failed to get information',
-  errorTitle: 'Error',
+  errorMessage: 'The operation could not be completed',
+  errorTitle: 'Error ',
   isFriend: 'Is Friend?',
   logOut: 'Logout',
   name: 'Name',

example/app/(app)/login.tsx

@@ -21,7 +21,7 @@ export default function () {
       .then(result => {
         if (!result.accessToken.accessToken) return
         setLocalStorageItem('accessToken', result.accessToken.accessToken)
-        router.replace('/home')
+        router.replace('/')
       })
       .catch(() => {
         Alert.alert(strings.errorTitle, strings.errorMessage)

example/app/_layout.tsx

@@ -6,39 +6,24 @@ import {
   ThemeProvider,
 } from '@react-navigation/native'
 import Line from '@xmartlabs/react-native-line'
-import { useFonts } from 'expo-font'
-import { Stack } from 'expo-router'
-import * as SplashScreen from 'expo-splash-screen'
+import { Slot } from 'expo-router'
 import { StatusBar } from 'expo-status-bar'
-import { useEffect } from 'react'
+import { useLayoutEffect } from 'react'
 
-import SpaceMono from '@/assets/fonts/SpaceMono-Regular.ttf'
+import { SplashScreen } from '@/components/SplashScreen'
 import { useColorScheme } from '@/hooks/useColorScheme'
 
-SplashScreen.preventAutoHideAsync()
-
 export default function () {
   const colorScheme = useColorScheme()
-  const [loaded] = useFonts({ SpaceMono })
-
-  useEffect(() => {
-    if (loaded) {
-      Line.setup({ channelId: '2006826760' })
-      SplashScreen.hideAsync()
-    }
-  }, [loaded])
 
-  if (!loaded) {
-    return null
-  }
+  useLayoutEffect(() => {
+    Line.setup({ channelId: '2006826760' })
+  }, [])
 
   return (
     <ThemeProvider value={colorScheme === 'dark' ? DarkTheme : DefaultTheme}>
-      <Stack screenOptions={{ headerShown: false }}>
-        <Stack.Screen name="(app)/login" />
-        <Stack.Screen name="(app)/home" />
-        <Stack.Screen name="+not-found" />
-      </Stack>
+      <SplashScreen />
+      <Slot />
       <StatusBar style="auto" />
     </ThemeProvider>
   )

example/app/index.tsx

@@ -0,0 +1,10 @@
+export class LineError extends Error {
+  public userInfo?: {
+    message: string
+    statusCode: number
+  }
+
+  constructor(message: string) {
+    super(message)
+  }
+}

example/common/errors.ts

@@ -0,0 +1,21 @@
+import 'react-native-reanimated'
+
+import { useFonts } from 'expo-font'
+import * as ExpoSplashScreen from 'expo-splash-screen'
+import { FunctionComponent, useEffect } from 'react'
+
+import SpaceMono from '@/assets/fonts/SpaceMono-Regular.ttf'
+
+ExpoSplashScreen.preventAutoHideAsync()
+
+export const SplashScreen: FunctionComponent = () => {
+  const [loaded] = useFonts({ SpaceMono })
+
+  useEffect(() => {
+    if (loaded) {
+      ExpoSplashScreen.hideAsync()
+    }
+  }, [loaded])
+
+  return null
+}

example/components/SplashScreen/index.tsx

@@ -39,7 +39,7 @@
   },
   "devDependencies": {
     "@babel/core": "^7.28.0",
-    "@types/react": "~19.1.8",
+    "@types/react": "~19.0.10",
     "react-native-svg-transformer": "^1.5.1"
   },
   "private": true

example/package-lock.json

@@ -2,7 +2,7 @@ import Foundation
 import LineSDK
 
 @objc(LineLogin) public class LineLogin: NSObject {
-
+  
   @objc public static func application(
     _ application: UIApplication,
     open url: URL,
@@ -21,27 +21,27 @@ import LineSDK
 
   @objc func setup(_ arguments: NSDictionary, resolver resolve: @escaping RCTPromiseResolveBlock,
                    rejecter reject: @escaping RCTPromiseRejectBlock) {
-
-    if LoginManager.shared.isSetupFinished {
-        reject("SETUP_ALREADY_COMPLETED", "Setup has already been completed", nil)
-        return
+    
+    guard !LoginManager.shared.isSetupFinished else {
+      reject("SETUP_ALREADY_COMPLETED", "Setup is already completed", nil)
+      return
     }
-
+    
     guard let channelID = arguments["channelId"] as? String else {
       reject("INVALID_ARGUMENTS", "Missing required argument: channelId", nil)
       return
     }
 
     let universalLinkURL: URL? = (arguments["universalLinkUrl"] as? String).flatMap { URL(string: $0) }
-    
-    return LoginManager.shared.setup(channelID: channelID, universalLinkURL: universalLinkURL)
+    LoginManager.shared.setup(channelID: channelID, universalLinkURL: universalLinkURL)
+    resolve(nil)
   }
 
   @objc func login(_ arguments: NSDictionary?, resolver resolve: @escaping RCTPromiseResolveBlock,
                    rejecter reject: @escaping RCTPromiseRejectBlock) {
 
     guard let args = arguments else {
-      LineLogin.nilArgument(reject)
+      reject("INVALID_ARGUMENTS", "Expected argument is nil", NSError(domain: "", code: 200, userInfo: nil))
       return
     }
 
@@ -84,12 +84,20 @@ import LineSDK
 
   @objc func getCurrentAccessToken(_ resolve: @escaping RCTPromiseResolveBlock,
                                    rejecter reject: @escaping RCTPromiseRejectBlock) {
-    if let token = AccessTokenStore.shared.current {
-      resolve(self.parseAccessToken(token))
-    }else{
-      reject("Error getting access token",
-             "There isn't an access token available",
-             NSError(domain: "", code: 200, userInfo: nil))
+    guard let token = AccessTokenStore.shared.current else {
+      reject("ACCESS_TOKEN_NOT_AVAILABLE", "No access token is available", nil)
+      return
+    }
+    resolve(self.parseAccessToken(token))
+  }
+  
+  @objc func getFriendshipStatus(_ resolve: @escaping RCTPromiseResolveBlock,
+                                 rejecter reject: @escaping RCTPromiseRejectBlock) {
+    API.getBotFriendshipStatus { result in
+      switch result {
+      case .success(let status): resolve(self.parseFriendshipStatus(status))
+      case .failure(let error): error.rejecter(reject)
+      }
     }
   }
 
@@ -123,43 +131,26 @@ import LineSDK
     }
   }
 
-  @objc func getFriendshipStatus(_ resolve: @escaping RCTPromiseResolveBlock,
-                                 rejecter reject: @escaping RCTPromiseRejectBlock) {
-    API.getBotFriendshipStatus { result in
-      switch result {
-      case .success(let status): resolve(self.parseFriendshipStatus(status))
-      case .failure(let error): error.rejecter(reject)
-      }
-    }
-  }
-  
-  static func nilArgument(_ reject: @escaping RCTPromiseRejectBlock) {
-    return reject(
-      "argument.nil",
-      "Expect an argument when invoking method, but it is nil.",
-      NSError(domain: "", code: 200, userInfo: nil))
+  private func parseFriendshipStatus(_ status: GetBotFriendshipStatusRequest.Response) -> NSDictionary {
+    return [
+      "friendFlag": status.friendFlag
+    ]
   }
 
-  private func parseAccessToken(_ token: AccessToken) -> NSDictionary {
-    var result = [
-      "accessToken": token.value,
-      "createdAt": token.createdAt,
-      "expiresIn": token.expiresAt,
-    ] as [String : Any]
-
-    if let idToken = token.IDTokenRaw {
+  private func parseAccessToken(_ accessToken: AccessToken) -> NSDictionary {
+    var result: [String: Any] = [
+      "accessToken": accessToken.value,
+      "createdAt": accessToken.createdAt,
+      "expiresIn": accessToken.expiresAt,
+    ]
+    
+    if let idToken = accessToken.IDTokenRaw {
       result["idToken"] = idToken
     }
-
+    
     return NSDictionary(dictionary: result)
   }
 
-  private func parseFriendshipStatus(_ status: GetBotFriendshipStatusRequest.Response) -> NSDictionary {
-    return [
-      "friendFlag": status.friendFlag
-    ]
-  }
-  
   private func parseProfile(_ profile: UserProfile) -> NSDictionary {
     return [
       "displayName": profile.displayName,
@@ -179,43 +170,19 @@ import LineSDK
     ]
   }
 
-  private func parseVerifyAccessToken(_ verification: AccessTokenVerifyResult) -> NSDictionary {
+  private func parseVerifyAccessToken(_ accessToken: AccessTokenVerifyResult) -> NSDictionary {
     return [
-      "channelId": verification.channelID,
-      "expiresIn": verification.expiresIn,
-      "scope": verification.permissions.map { $0.rawValue }.joined(separator: " ")
+      "channelId": accessToken.channelID,
+      "expiresIn": accessToken.expiresIn,
+      "scope": accessToken.permissions.map { $0.rawValue }.joined(separator: " ")
     ]
   }
 }
 
-
-extension Encodable {
-  func toJSON() throws -> Any {
-    let data = try JSONEncoder().encode(self)
-    return try JSONSerialization.jsonObject(with: data, options: [])
-  }
-  func errorParsing(_ reject: @escaping RCTPromiseRejectBlock, _ name: String) {
-    return reject(
-      "error parsing",
-      "There was an error when parsing `\(name)`",
-      NSError(domain: "", code: 200, userInfo: nil))
-  }
-  
-  func resolver(_ resolve: @escaping RCTPromiseResolveBlock, _ reject: @escaping RCTPromiseRejectBlock, name: String) {
-    do {
-      let jsonValue = try self.toJSON()
-      resolve(jsonValue)
-    } catch {
-      self.errorParsing(reject, name)
-    }
-  }
-}
-
 extension LineSDKError {
   func rejecter(_ reject: @escaping RCTPromiseRejectBlock) {
-    reject(
-      "\(errorCode)",
-      errorDescription,
-      self)
+    let code = String(errorCode)
+    let message = errorDescription ?? "Unknown error"
+    reject(code, message, self)
   }
 }