-
Notifications
You must be signed in to change notification settings - Fork 52
DVDDemuxFFmpeg: Pass three more ffmpeg options #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Piers
Are you sure you want to change the base?
Conversation
|
I forgot to wrote that I'm not really sure how to pass this options from m3u8 list to ffmpeg? In my opinion this should be addon setting? Like "Disable strict HLS file extension check" and "Allowed HLS extensions". It is annoying to fix all channels when it can be done on one place only. |
3f75a92 to
d8c2d70
Compare
allows to play HLS stream without extension related to FFmpeg/FFmpeg@b753bac 2025-10-16 18:51:56.563 T:885 error <general>: ffmpeg[0x6ff2e90]: [hls] URL https://some.server.com/stream/fragment/ts/live/?session=163ec3ad-7f2e-4f16-be20-062a73733b56&offset=192639&pointeroffset=39&fragmentlength=4800 is not in allowed_extensions
d8c2d70 to
74ad74f
Compare
related to xbmc#344 use correct class methods from ffmpegdirect UrlOptions.cpp and not from Kodi which uses same class name before 2025-10-31 18:29:33.622 T:10030 debug <inputstream.ffmpegdirect>: CDVDDemuxFFmpeg::GetFFMpegOptionsFromInput() adding ffmpeg option 'extension_picky: ' after 2025-10-31 18:31:16.884 T:10126 debug <inputstream.ffmpegdirect>: CDVDDemuxFFmpeg::GetFFMpegOptionsFromInput() adding ffmpeg option 'extension_picky: 0'
|
Is this good to go now? |
|
It is. But in my opinion it would be better to put this Option |
|
Or maybe even better would be to just set option explicitly because user want to play stream regardless of such restriction in ffmpeg. And manually allowing this option to enable playing of the stream doesn't fix any security concern.
but because of security implications maybe not best GHSA-398c-f7w9-crc8 |
|
Maybe adding to addon settings would be prefered way because disabling extension check does have some security implications. That's why this change in ffmpeg was even made: GHSA-398c-f7w9-crc8 |

allows to play HLS stream without extension in url
related to FFmpeg/FFmpeg@b753bac
2025-10-16 18:51:56.563 T:885 error <general>: ffmpeg[0x6ff2e90]: [hls] URL https://some.server.com/stream/fragment/ts/live/?session=163ec3ad-7f2e-4f16-be20-062a73733b56&offset=192639&pointeroffset=39&fragmentlength=4800 is not in allowed_extensions