Add mass unreconiling ff (#5661)

Author: diebas

app/controllers/facility_journals_controller.rb

@@ -141,6 +141,10 @@ def reconcile
   end
 
   def unreconcile
+    unless SettingsHelper.feature_on?(:allow_mass_unreconciling)
+      raise CanCan::AccessDenied, I18n.t("controllers.facility_journals.unreconcile.feature_disabled")
+    end
+
     process_reconciliation(:unreconcile)
   end
 

app/views/facility_journals/show.html.haml

@@ -45,7 +45,7 @@
   - has_reconciled = @journal.order_details.where(state: "reconciled").any?
   - has_unreconciled = @journal.order_details.where.not(state: "reconciled").any?
   - journal_can_reconcile = @journal.successful? && has_unreconciled
-  - journal_can_unreconcile = @journal.successful? && has_reconciled
+  - journal_can_unreconcile = @journal.successful? && has_reconciled && SettingsHelper.feature_on?(:allow_mass_unreconciling)
   - show_checkboxes = journal_is_submittable || journal_can_unreconcile || journal_can_reconcile
 
   = form_tag facility_journal_reconcile_path(current_facility, @journal), method: :post, id: "journal-form" do

config/locales/en.controllers.yml

@@ -73,6 +73,7 @@ en:
         success: "%{count} payment(s) successfully unreconciled"
         errors:
           none_eligible: "No orders were selected or eligible to unreconcile"
+        feature_disabled: "Mass unreconciling is not enabled"
 
     facility_order_details:
       destroy:

config/settings.yml

@@ -182,6 +182,7 @@ feature:
   account_tabs: false
   user_based_price_groups_exclude_purchaser: false
   item_initial_order_status_complete: false
+  allow_mass_unreconciling: false
 
 split_accounts:
   # Roles are allowed to create Split Accounts

spec/controllers/facility_journals_controller_spec.rb

@@ -512,107 +512,115 @@ def perform(order_detail_params = nil)
       @journal.create_journal_rows!([@order_detail1, @order_detail2, @order_detail3])
     end
 
-    describe "when all order details are reconciled" do
-      before do
-        @order_detail1.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
-        @order_detail2.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
-        @order_detail3.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+    context "when feature flag is disabled", feature_setting: { allow_mass_unreconciling: false } do
+      it "raises access denied error" do
+        expect { perform }.to raise_error(CanCan::AccessDenied)
       end
+    end
 
-      it "unreconciles all order details" do
-        perform
-        expect(@order_detail1.reload.state).to eq("complete")
-        expect(@order_detail2.reload.state).to eq("complete")
-        expect(@order_detail3.reload.state).to eq("complete")
-      end
+    context "when feature flag is enabled", feature_setting: { allow_mass_unreconciling: true } do
+      describe "when all order details are reconciled" do
+        before do
+          @order_detail1.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+          @order_detail2.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+          @order_detail3.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+        end
 
-      it "clears reconciled_at for all order details" do
-        perform
-        expect(@order_detail1.reload.reconciled_at).to be_nil
-        expect(@order_detail2.reload.reconciled_at).to be_nil
-        expect(@order_detail3.reload.reconciled_at).to be_nil
-      end
+        it "unreconciles all order details" do
+          perform
+          expect(@order_detail1.reload.state).to eq("complete")
+          expect(@order_detail2.reload.state).to eq("complete")
+          expect(@order_detail3.reload.state).to eq("complete")
+        end
 
-      it "sets flash notice with correct count" do
-        perform
-        expect(flash[:notice]).to eq("3 payment(s) successfully unreconciled")
-      end
-    end
+        it "clears reconciled_at for all order details" do
+          perform
+          expect(@order_detail1.reload.reconciled_at).to be_nil
+          expect(@order_detail2.reload.reconciled_at).to be_nil
+          expect(@order_detail3.reload.reconciled_at).to be_nil
+        end
 
-    describe "when some order details are not reconciled" do
-      before do
-        @order_detail1.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
-        @order_detail2.update!(state: "complete")
-        @order_detail3.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+        it "sets flash notice with correct count" do
+          perform
+          expect(flash[:notice]).to eq("3 payment(s) successfully unreconciled")
+        end
       end
 
-      it "only unreconciles the reconciled ones" do
-        perform
-        expect(@order_detail1.reload.state).to eq("complete")
-        expect(@order_detail2.reload.state).to eq("complete")
-        expect(@order_detail3.reload.state).to eq("complete")
-      end
+      describe "when some order details are not reconciled" do
+        before do
+          @order_detail1.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+          @order_detail2.update!(state: "complete")
+          @order_detail3.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+        end
 
-      it "shows correct count in flash notice" do
-        perform
-        expect(flash[:notice]).to eq("2 payment(s) successfully unreconciled")
-      end
-    end
+        it "only unreconciles the reconciled ones" do
+          perform
+          expect(@order_detail1.reload.state).to eq("complete")
+          expect(@order_detail2.reload.state).to eq("complete")
+          expect(@order_detail3.reload.state).to eq("complete")
+        end
 
-    describe "when no order details are reconciled" do
-      before do
-        @order_detail1.update!(state: "complete")
-        @order_detail2.update!(state: "complete")
-        @order_detail3.update!(state: "complete")
+        it "shows correct count in flash notice" do
+          perform
+          expect(flash[:notice]).to eq("2 payment(s) successfully unreconciled")
+        end
       end
 
-      it "does not change any states" do
-        perform
-        expect(@order_detail1.reload.state).to eq("complete")
-        expect(@order_detail2.reload.state).to eq("complete")
-        expect(@order_detail3.reload.state).to eq("complete")
-      end
+      describe "when no order details are reconciled" do
+        before do
+          @order_detail1.update!(state: "complete")
+          @order_detail2.update!(state: "complete")
+          @order_detail3.update!(state: "complete")
+        end
 
-      it "shows appropriate flash error" do
-        perform
-        expect(flash[:error]).to eq("No orders were selected or eligible to unreconcile")
+        it "does not change any states" do
+          perform
+          expect(@order_detail1.reload.state).to eq("complete")
+          expect(@order_detail2.reload.state).to eq("complete")
+          expect(@order_detail3.reload.state).to eq("complete")
+        end
+
+        it "shows appropriate flash error" do
+          perform
+          expect(flash[:error]).to eq("No orders were selected or eligible to unreconcile")
+        end
       end
-    end
 
-    describe "when unreconcile fails for one order detail" do
-      before do
-        @order_detail1.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
-        @order_detail2.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
-        @order_detail3.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
-
-        allow_any_instance_of(OrderDetail).to receive(:update!).and_call_original
-
-        call_count = 0
-        allow_any_instance_of(OrderDetail).to receive(:update!).and_wrap_original do |original, receiver, *args|
-          call_count += 1
-          if call_count == 2 # Fail on the second order detail
-            raise StandardError, "Failed to update order detail"
-          else
-            original.call(receiver, *args)
+      describe "when unreconcile fails for one order detail" do
+        before do
+          @order_detail1.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+          @order_detail2.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+          @order_detail3.update!(state: "reconciled", reconciled_at: 1.day.ago, order_status: OrderStatus.reconciled)
+
+          allow_any_instance_of(OrderDetail).to receive(:update!).and_call_original
+
+          call_count = 0
+          allow_any_instance_of(OrderDetail).to receive(:update!).and_wrap_original do |original, receiver, *args|
+            call_count += 1
+            if call_count == 2 # Fail on the second order detail
+              raise StandardError, "Failed to update order detail"
+            else
+              original.call(receiver, *args)
+            end
           end
         end
-      end
 
-      it "rolls back all changes" do
-        perform
-        expect(@order_detail1.reload.state).to eq("reconciled")
-        expect(@order_detail2.reload.state).to eq("reconciled")
-        expect(@order_detail3.reload.state).to eq("reconciled")
-      end
+        it "rolls back all changes" do
+          perform
+          expect(@order_detail1.reload.state).to eq("reconciled")
+          expect(@order_detail2.reload.state).to eq("reconciled")
+          expect(@order_detail3.reload.state).to eq("reconciled")
+        end
 
-      it "shows error message with the failing order detail" do
-        perform
-        expect(flash[:error]).to include("Failed to update order detail")
-      end
+        it "shows error message with the failing order detail" do
+          perform
+          expect(flash[:error]).to include("Failed to update order detail")
+        end
 
-      it "does not show success message" do
-        perform
-        expect(flash[:notice]).to be_nil
+        it "does not show success message" do
+          perform
+          expect(flash[:notice]).to be_nil
+        end
       end
     end
   end