Skip to content

Update jackson-datatype-jdk8, ... to 2.20.1 #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xerial-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update jackson-datatype-jdk8, ... to 2.20.1 #4086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,8 +973,8 @@ lazy val fluentd =
// td-client-java -> json-simple happened to include junit 4.10 [CVE-2020-15250]
exclude ("junit", "junit"),
// Necessary for td-client-java, which is used in fluency-treasuredata
"com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.18.5" % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % "2.18.5" % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.20.1" % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % "2.20.1" % Provided,
Comment on lines +976 to +977
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and consistency with how other versions are managed in this file, it's a good practice to define a val for the version number at the top of the file and reuse it, especially when it's shared between multiple dependencies.

If you add val JACKSON_DATATYPE_VERSION = "2.20.1" at the top of the file with other version definitions, you can then apply the following suggestion.

        "com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % JACKSON_DATATYPE_VERSION % Provided,
        "com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8"     % JACKSON_DATATYPE_VERSION % Provided,

// Redirecting slf4j log from Fluency to aiframe-log
"org.slf4j" % "slf4j-jdk14" % SLF4J_VERSION
)
Expand Down
Loading