Throw a client error if an idp not found for the issuer name #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
218
to
+221
| String resourceResidentOrgId = PrivilegedCarbonContext.getThreadLocalCarbonContext().getOrganizationId(); | ||
| if (!jwtIssuerOrgId.equals(switchedOrgOrgAncestors.get(depthOfRootOrg)) || | ||
| !resourceResidentOrgId.equals(switchedOrgId)) { | ||
| throw new IdentityOAuth2Exception("No registered IDP found for the token with issuer name : " | ||
| throw new IdentityOAuth2ClientException("No registered IDP found for the token with issuer name : " |
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| String resourceResidentOrgId = PrivilegedCarbonContext.getThreadLocalCarbonContext().getOrganizationId(); | |
| if (!jwtIssuerOrgId.equals(switchedOrgOrgAncestors.get(depthOfRootOrg)) || | |
| !resourceResidentOrgId.equals(switchedOrgId)) { | |
| throw new IdentityOAuth2Exception("No registered IDP found for the token with issuer name : " | |
| throw new IdentityOAuth2ClientException("No registered IDP found for the token with issuer name : " | |
| String resourceResidentOrgId = PrivilegedCarbonContext.getThreadLocalCarbonContext().getOrganizationId(); | |
| if (!jwtIssuerOrgId.equals(switchedOrgOrgAncestors.get(depthOfRootOrg)) || | |
| !resourceResidentOrgId.equals(switchedOrgId)) { | |
| log.error("No registered IDP found for JWT issuer: " + jwtIssuer + ", jwtIssuerOrgId: " + jwtIssuerOrgId + ", resourceResidentOrgId: " + resourceResidentOrgId); |
Contributor
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 |
AnuradhaSK
approved these changes
Nov 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2984 +/- ##
============================================
- Coverage 56.88% 55.98% -0.91%
- Complexity 9608 9884 +276
============================================
Files 669 669
Lines 54806 57392 +2586
Branches 12545 13438 +893
============================================
+ Hits 31179 32133 +954
- Misses 19239 20658 +1419
- Partials 4388 4601 +213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
note $subject