Merge pull request #14179 from wordpress-mobile/fix/14178-do-not-start-qs-for-previously-selected-site

Start QS only for the newly created site

Author: renanferrari

WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java

@@ -1060,7 +1060,6 @@ public void onClick(View v) {
                 }
                 break;
             case RequestCodes.CREATE_SITE:
-                passOnActivityResultToMySiteFragment(requestCode, resultCode, data);
                 QuickStartUtils.cancelQuickStartReminder(this);
                 AppPrefs.setQuickStartNoticeRequired(false);
                 AppPrefs.setLastSkippedQuickStartTask(null);
@@ -1096,7 +1095,6 @@ public void onClick(View v) {
                 }
                 break;
             case RequestCodes.SITE_PICKER:
-                passOnActivityResultToMySiteFragment(requestCode, resultCode, data);
                 if (getMySiteFragment() != null) {
                     boolean isSameSiteSelected = data != null
                                                  && data.getIntExtra(SitePickerActivity.KEY_LOCAL_ID, -1) == AppPrefs

WordPress/src/main/java/org/wordpress/android/ui/mysite/ImprovedMySiteFragment.kt

@@ -434,11 +434,11 @@ class ImprovedMySiteFragment : Fragment(),
                 viewModel.handleSuccessfulDomainRegistrationResult(data.getStringExtra(RESULT_REGISTERED_DOMAIN_EMAIL))
             }
             RequestCodes.CREATE_SITE -> {
-                viewModel.startQuickStart()
+                viewModel.startQuickStart(data.getIntExtra(SitePickerActivity.KEY_LOCAL_ID, -1))
             }
             RequestCodes.SITE_PICKER -> {
                 if (data.getIntExtra(WPMainActivity.ARG_CREATE_SITE, 0) == RequestCodes.CREATE_SITE) {
-                    viewModel.startQuickStart()
+                    viewModel.startQuickStart(data.getIntExtra(SitePickerActivity.KEY_LOCAL_ID, -1))
                 }
             }
         }

WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt

@@ -574,8 +574,8 @@ class MySiteViewModel
         }
     }
 
-    fun startQuickStart() {
-        quickStartRepository.startQuickStart()
+    fun startQuickStart(newSiteLocalID: Int) {
+        quickStartRepository.startQuickStart(newSiteLocalID)
     }
 
     fun onQuickStartMenuInteraction(interaction: DynamicCardMenuInteraction) {

WordPress/src/main/java/org/wordpress/android/ui/mysite/QuickStartRepository.kt

@@ -108,9 +108,9 @@ class QuickStartRepository
         }
     }
 
-    fun startQuickStart() {
-        selectedSiteRepository.getSelectedSite()?.let { site ->
-            quickStartStore.setDoneTask(site.id.toLong(), CREATE_SITE, true)
+    fun startQuickStart(newSiteLocalID: Int) {
+        if (newSiteLocalID != -1) {
+            quickStartStore.setDoneTask(newSiteLocalID.toLong(), CREATE_SITE, true)
             refresh()
         }
     }

WordPress/src/test/java/org/wordpress/android/ui/mysite/QuickStartRepositoryTest.kt

@@ -139,10 +139,9 @@ class QuickStartRepositoryTest : BaseUnitTest() {
 
     @Test
     fun `start marks CREATE_SITE as done and loads model`() = test {
-        whenever(selectedSiteRepository.getSelectedSite()).thenReturn(site)
         initStore()
 
-        quickStartRepository.startQuickStart()
+        quickStartRepository.startQuickStart(siteId)
 
         verify(quickStartStore).setDoneTask(siteId.toLong(), CREATE_SITE, true)
         assertModel()