bug: $USER env var value can be empty

[luke-han]

Checks

• I have searched github.com/withfig/fig/issues and there are no duplicates of my issue
• I have run fig doctor in the affected terminal session
• I have run fig restart and replicated the issue again

Operating system

MacOS 14.4

Expected behaviour

Access to remote machine with forklift 3

Actual behaviour

Can't access to remote machine with the following error.

vdollar_percent_expand: env var ${USER} has no value

If I replace $USER env var with the actual name in ~/.fig/ssh_inner, it works well.

Steps to reproduce

• Install fig
• Access remote machine (ssh) with forklift 3.5.8

Environment

fig-details:
  - 2.18.1
hardware-info:
  - model:
  - model-id:
  - chip-id: Apple M2 Max
  - cores: 12
  - mem: 32.00 GB
os-info:
  - macOS 14.4.0 (23E214)
environment:
  - shell: /bin/zsh
  - terminal: iterm
  - cwd: /Users/luke
  - exe-path: /opt/homebrew/bin/fig
  - install-method: brew
  - env-vars:
    - SHELL: /bin/zsh
    - __CFBundleIdentifier: com.googlecode.iterm2
    - PATH: /opt/homebrew/opt/opencv@3/bin:/opt/homebrew/anaconda3/bin:/opt/homebrew/anaconda3/condabin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/Users/luke/Library/Android/sdk/platform-tools:/Users/luke/.local/bin
    - TERM: xterm-256color

[mschrage]

Hi @luke-han, thanks for reporting this. It looks Forklift doesn't set the $USER environment variable and this breaks our SSH integration.

I can't give a timeframe for us resolving this issue, so I'd suggest removing the Fig ssh integration in the meantime.

Run fig integrations uninstall ssh