fix: correctly implement SQL parameter replacement as pyformat paramstyle

Author: mpetazzoni

wherobots/__init__.py

@@ -19,6 +19,8 @@
 MAX_MESSAGE_SIZE: int = 100 * 2**20  # 100MiB
 PROTOCOL_VERSION: Version = Version("1.0.0")
 
+PARAM_STYLE = "pyformat"
+
 
 class ExecutionState(LowercaseStrEnum):
     IDLE = auto()

wherobots/db/constants.py

@@ -80,10 +80,9 @@ def execute(self, operation: str, parameters: Dict[str, Any] = None) -> None:
         self.__rowcount = -1
         self.__description = None
 
-        sql = (
-            operation.replace("{", "{{").replace("}", "}}").format(**(parameters or {}))
+        self.__current_execution_id = self.__exec_fn(
+            operation % (parameters or {}), self.__on_execution_result
         )
-        self.__current_execution_id = self.__exec_fn(sql, self.__on_execution_result)
 
     def executemany(
         self, operation: str, seq_of_parameters: List[Dict[str, Any]]

wherobots/db/cursor.py

@@ -11,7 +11,7 @@
 import platform
 import requests
 import tenacity
-from typing import Union, Dict
+from typing import Final, Union, Dict
 import urllib.parse
 import websockets.sync.client
 import certifi
@@ -25,6 +25,7 @@
     DEFAULT_SESSION_TYPE,
     DEFAULT_SESSION_WAIT_TIMEOUT_SECONDS,
     MAX_MESSAGE_SIZE,
+    PARAM_STYLE,
     PROTOCOL_VERSION,
     AppStatus,
     DataCompression,
@@ -41,7 +42,7 @@
 
 apilevel = "2.0"
 threadsafety = 1
-paramstyle = "pyformat"
+paramstyle: Final[str] = PARAM_STYLE
 
 
 def gen_user_agent_header():