Skip to content

Commit a8090ef

Browse files
Add dev server test data for an experimental run of Edge
This adds a test run for edge experimental on the testing sha 24278ab. It reuses the same json results as edge[stable]. The goal is to make the webdriver tests more like reality (e.g. there should be 4 experimental browsers by default) and to allow us to remove the obsolete experimentalAlignedExceptEdge flag (which is off in prod/staging but still on for the dev server!)
1 parent e9d3fdb commit a8090ef

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

util/populate_dev_data.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,11 @@ func main() {
8989
edge.ResultsURL = fmt.Sprintf(summaryURLFmtString, *localHost, staticRunSHA[:10], "edge[stable].json")
9090
edge.Labels = []string{"edge", shared.StableLabel}
9191

92+
edgeExp := edge
93+
edgeExp.BrowserVersion = "20"
94+
edgeExp.ResultsURL = strings.Replace(edge.ResultsURL, "[stable]", "[experimental]", -1)
95+
edgeExp.Labels = []string{"edge", shared.ExperimentalLabel}
96+
9297
firefox := chrome
9398
firefox.BrowserName = "firefox"
9499
firefox.BrowserVersion = "66"
@@ -115,6 +120,7 @@ func main() {
115120
chrome,
116121
chromeExp,
117122
edge,
123+
edgeExp,
118124
firefox,
119125
firefoxExp,
120126
safari,

webapp/static/24278ab617/edge[experimental].json

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

webdriver/label_test.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,8 @@ import (
1515

1616
func TestLabelParam_Results(t *testing.T) {
1717
runWebdriverTest(t, func(t *testing.T, app AppServer, wd selenium.WebDriver) {
18-
// Local static data only have 2 experimental browsers, and neither has aligned
19-
// experimental runs.
20-
if *staging {
21-
testLabel(t, wd, app, "/", "experimental", "wpt-results", 4, false)
22-
} else {
23-
testLabel(t, wd, app, "/", "experimental", "wpt-results", 3, false)
24-
}
18+
aligned := false
19+
testLabel(t, wd, app, "/", "experimental", "wpt-results", 4, aligned)
2520
})
2621

2722
}

0 commit comments

Comments
 (0)