Return an error in case when total block complexity exceeds limit.

nickeskov · nickeskov · commit a7c3735762aa · 2022-06-15T00:49:13.000+03:00
diff --git a/pkg/state/appender.go b/pkg/state/appender.go
@@ -275,8 +275,9 @@ func (a *txAppender) checkScriptsLimits(scriptsRuns uint64, blockID proto.BlockI
 		}
 		maxBlockComplexity := NewMaxScriptsComplexityInBlock().GetMaxScriptsComplexityInBlock(rideV5Activated)
 		if a.sc.getTotalComplexity() > uint64(maxBlockComplexity) {
-			// TODO this is definitely an error, should return it
-			zap.S().Warnf("Complexity of scripts (%d) in block '%s' exceeds limit of %d", a.sc.getTotalComplexity(), blockID.String(), maxBlockComplexity)
+			return errors.Errorf("complexity of scripts (%d) in block '%s' exceeds limit of %d",
+				a.sc.getTotalComplexity(), blockID.String(), maxBlockComplexity,
+			)
 		}
 		return nil
 	} else if smartAccountsActivated {

Original file line number	Diff line number	Diff line change
`@@ -275,8 +275,9 @@ func (a *txAppender) checkScriptsLimits(scriptsRuns uint64, blockID proto.BlockI`
`275`	`275`	`}`
`276`	`276`	`maxBlockComplexity := NewMaxScriptsComplexityInBlock().GetMaxScriptsComplexityInBlock(rideV5Activated)`
`277`	`277`	`if a.sc.getTotalComplexity() > uint64(maxBlockComplexity) {`
`278`		`- // TODO this is definitely an error, should return it`
`279`		`- zap.S().Warnf("Complexity of scripts (%d) in block '%s' exceeds limit of %d", a.sc.getTotalComplexity(), blockID.String(), maxBlockComplexity)`
	`278`	`+ return errors.Errorf("complexity of scripts (%d) in block '%s' exceeds limit of %d",`
	`279`	`+ a.sc.getTotalComplexity(), blockID.String(), maxBlockComplexity,`
	`280`	`+ )`
`280`	`281`	`}`
`281`	`282`	`return nil`
`282`	`283`	`} else if smartAccountsActivated {`