-
Notifications
You must be signed in to change notification settings - Fork 577
PolkadotJS hardware wallets support #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
310ea5e
Added polkadotjs for hardware wallets milestone 2
akru 8e202a3
Added polkadotjs for hardware wallets milestone 1
akru fd6e889
fix documentation links
akru 2bdacdf
Fix custom-signatures pallet location
akru 43af59f
polkadotjs-ecdsa-hardware: update docs links
akru 3317822
Delete polkadotjs-ecdsa-hardware-milestone-1.md
alxs f1cb16e
Update and rename polkadotjs-ecdsa-hardware-milestone-2.md to polkado…
alxs c62f782
Update deliveries/polkadotjs-ecdsa-hardware-milestone-1.md
alxs 444d046
updated links in the delivery file
gluneau 861d114
Merge pull request #1 from gluneau/polkadotjs-ecdsa-hardware
akru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Milestone Delivery :mailbox: | ||
|
|
||
| **The [invoice form :pencil:](https://forms.gle/8Wx7nxtq8fKrsuEz8) has been filled out correctly for this milestone.** | ||
|
|
||
| * **PR Link:** [ECDSA for Polkadot JS](https://github.com/w3f/Open-Grants-Program/pull/39) | ||
| * **Milestone Number:** 1 | ||
|
|
||
| Please provide a list of all deliverables of the milestone extracted from the initial application and a link to the deliverable itself. Ideally all links inside the below table should include a commit hash, which should be used for testing. | ||
|
|
||
| | Number | Deliverable | Link | Notes | | ||
| | ------------- | ------------- | ------------- |------------- | | ||
| | 1. | Ledger API ECDSA signer | [pallet](https://github.com/AstarNetwork/astar-frame/tree/polkadot-v0.9.24/frame/custom-signatures), [UI](https://github.com/hoonsubin/apps/pull/2/files) | Ledger support consist of two components: the pallet (that supports any signature schemes to send transactions), and UI that requests Metamask to sign custom data (the `Call` structure). | | ||
| | 2. | Improve documentation | https://astarnetwork.notion.site/Backup-MetaMask-Support-ed399d80c11e4202a056776c20c64370 | Added documentation page that describes provided functionality. | | ||
| | 3. | Demo video | [Link](https://user-images.githubusercontent.com/40356749/104814290-7137a700-5851-11eb-8cef-00b9495da0d6.mp4) | Attached to [PR](https://github.com/hoonsubin/apps/pull/2). | | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.