-
Notifications
You must be signed in to change notification settings - Fork 82
Fix normative notes and clarify/simplify robustness rules #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joeyparrish
wants to merge
1
commit into
main
Choose a base branch
from
normative-robustness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2544,20 +2544,19 @@ <h2> | |||||||||
| <p> | ||||||||||
| The robustness level associated with the content type. The empty string indicates | ||||||||||
| that any ability to decrypt and decode the content type is acceptable. | ||||||||||
| Implementations MUST configure the [=CDM=] to support at least the robustness | ||||||||||
| levels specified in the configuration of the {{MediaKeySystemAccess}} object used | ||||||||||
| to create the {{MediaKeys}} object. | ||||||||||
| </p> | ||||||||||
| <div class="note"> | ||||||||||
| <p> | ||||||||||
| Implementations MUST configure the [=CDM=] to support at least the robustness | ||||||||||
| levels specified in the configuration of the {{MediaKeySystemAccess}} object used | ||||||||||
| to create the {{MediaKeys}} object. Exact configuration of the [=CDM=] is | ||||||||||
| implementation-specific, and implementations MAY configure the [=CDM=] to use the | ||||||||||
| highest robustness level in the configuration even if a higher robustness level | ||||||||||
| is available. If only the empty string is specified, implementations MAY be | ||||||||||
| configured to use the lowest robustness level the implementation supports. | ||||||||||
| Exact configuration of the [=CDM=] is implementation-specific. | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We may want to remove the note entirely, and keep the "implementations MAY configure" language. |
||||||||||
| If only the empty string is specified, implementations have the option to | ||||||||||
| use the lowest robustness level the implementation supports. | ||||||||||
| </p> | ||||||||||
| <p> | ||||||||||
| Applications SHOULD specify the robustness level(s) they require to avoid | ||||||||||
| unexpected client incompatibilities. | ||||||||||
| Applications are recommended to specify the robustness level(s) they require, | ||||||||||
| if any, to avoid unexpected client incompatibilities. | ||||||||||
|
Comment on lines
+2558
to
+2559
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| </p> | ||||||||||
| </div> | ||||||||||
| </dd> | ||||||||||
|
|
||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "MediaKeySystemAccess object" is right here - it's an interface, whereas MediaKeySystemConfiguration is a dictionary.