From feba1d60eca4ad64541138240f8ea8a4d65e4931 Mon Sep 17 00:00:00 2001 From: Fanny Chien Date: Mon, 10 Mar 2025 20:12:36 -0300 Subject: [PATCH] chore: adjust experimental prefix for button sign in --- .../components/navigation/Navbar/Navbar.tsx | 2 +- .../navigation/NavbarSlider/NavbarSlider.tsx | 6 ++--- .../sections/Navbar/DefaultComponents.ts | 2 +- packages/core/src/typings/overrides.ts | 24 +++++++++---------- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/packages/core/src/components/navigation/Navbar/Navbar.tsx b/packages/core/src/components/navigation/Navbar/Navbar.tsx index 6a5a4d6263..793ac8e936 100644 --- a/packages/core/src/components/navigation/Navbar/Navbar.tsx +++ b/packages/core/src/components/navigation/Navbar/Navbar.tsx @@ -93,7 +93,7 @@ function Navbar({ NavbarRow, NavbarButtons, IconButton, - _experimentalButtonSignIn: ButtonSignIn, + __experimentalButtonSignIn: ButtonSignIn, } = useOverrideComponents<'Navbar'>() const scrollDirection = useScrollDirection() const { openNavbar, navbar: displayNavbar } = useUI() diff --git a/packages/core/src/components/navigation/NavbarSlider/NavbarSlider.tsx b/packages/core/src/components/navigation/NavbarSlider/NavbarSlider.tsx index 888d586d31..e33e236b34 100644 --- a/packages/core/src/components/navigation/NavbarSlider/NavbarSlider.tsx +++ b/packages/core/src/components/navigation/NavbarSlider/NavbarSlider.tsx @@ -1,15 +1,15 @@ import { useFadeEffect, useUI } from '@faststore/ui' import { Suspense } from 'react' +import NavbarLinks from 'src/components/navigation/NavbarLinks' import { ButtonSignInFallback } from 'src/components/ui/Button' import Link from 'src/components/ui/Link' -import NavbarLinks from 'src/components/navigation/NavbarLinks' import Logo from 'src/components/ui/Logo' import type { NavbarProps } from '../Navbar' -import styles from './section.module.scss' import { useOverrideComponents } from 'src/sdk/overrides/OverrideContext' +import styles from './section.module.scss' interface NavbarSliderProps { logo: NavbarProps['logo'] @@ -31,7 +31,7 @@ function NavbarSlider({ NavbarSliderHeader, NavbarSliderContent, NavbarSliderFooter, - _experimentalButtonSignIn: ButtonSignIn, + __experimentalButtonSignIn: ButtonSignIn, } = useOverrideComponents<'Navbar'>() const { closeNavbar } = useUI() diff --git a/packages/core/src/components/sections/Navbar/DefaultComponents.ts b/packages/core/src/components/sections/Navbar/DefaultComponents.ts index b94dc97ff0..3e5c4dc290 100644 --- a/packages/core/src/components/sections/Navbar/DefaultComponents.ts +++ b/packages/core/src/components/sections/Navbar/DefaultComponents.ts @@ -49,5 +49,5 @@ export const NavbarDefaultComponents = { NavbarRow: UINavbarRow, NavbarButtons: UINavbarButtons, IconButton: UIIconButton, - _experimentalButtonSignIn: ButtonSignIn, + __experimentalButtonSignIn: ButtonSignIn, } as const diff --git a/packages/core/src/typings/overrides.ts b/packages/core/src/typings/overrides.ts index 65ef1869cf..ed22c15e67 100644 --- a/packages/core/src/typings/overrides.ts +++ b/packages/core/src/typings/overrides.ts @@ -1,4 +1,3 @@ -import type { PropsWithChildren } from 'react' import type { AlertProps, BannerTextContentProps, @@ -26,11 +25,11 @@ import type { NavbarSliderFooterProps, NavbarSliderHeaderProps, NavbarSliderProps, - NewsletterProps, NewsletterAddendumProps, NewsletterContentProps, NewsletterFormProps, NewsletterHeaderProps, + NewsletterProps, ProductPriceProps, ProductShelfProps, ProductTitleProps, @@ -38,28 +37,29 @@ import type { RegionBarProps, ShippingSimulationProps, SkeletonProps, - SkuSelectorProps, SKUMatrixProps, - SKUMatrixTriggerProps, SKUMatrixSidebarProps, + SKUMatrixTriggerProps, + SkuSelectorProps, } from '@faststore/ui' +import type { PropsWithChildren } from 'react' -import type { - ComponentOverrideDefinition, - SectionOverrideDefinitionV1, -} from './overridesDefinition' import type Alert from '../components/sections/Alert' -import type Breadcrumb from '../components/sections/Breadcrumb' import type BannerText from '../components/sections/BannerText' +import type Breadcrumb from '../components/sections/Breadcrumb' import type CrossSellingShelf from '../components/sections/CrossSellingShelf' import type EmptyState from '../components/sections/EmptyState' import type Hero from '../components/sections/Hero' -import type ProductShelf from '../components/sections/ProductShelf' -import type ProductDetails from '../components/sections/ProductDetails' import type Navbar from '../components/sections/Navbar' import type Newsletter from '../components/sections/Newsletter' +import type ProductDetails from '../components/sections/ProductDetails' import type ProductGallery from '../components/sections/ProductGallery' +import type ProductShelf from '../components/sections/ProductShelf' import type RegionBar from '../components/sections/RegionBar' +import type { + ComponentOverrideDefinition, + SectionOverrideDefinitionV1, +} from './overridesDefinition' export type SectionOverride = { [K in keyof SectionsOverrides]: SectionOverrideDefinitionV1 @@ -198,7 +198,7 @@ export type SectionsOverrides = { IconButtonProps, Omit > - _experimentalButtonSignIn: ComponentOverrideDefinition + __experimentalButtonSignIn: ComponentOverrideDefinition } } Newsletter: {