[Bugfix] Pod rolebinding are requiered even with k8s_discovery_mode=serivce-name (#744)

* pod is mandatory because of sleep-mode

Signed-off-by: nargit <[email protected]>

* Simplify bindings

Signed-off-by: nargit <[email protected]>

---------

Signed-off-by: nargit <[email protected]>
Co-authored-by: nargit <[email protected]>

Author: NargiT

helm/templates/role.yaml

@@ -1,25 +1,17 @@
 {{- if .Values.routerSpec.enableRouter -}}
-{{- if .Values.routerSpec.k8sServiceDiscoveryType | default "pod-ip" | eq "pod-ip" }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
-  name: "{{ .Release.Name }}-pod-reader"
+  name: "{{ .Release.Name }}-reader"
   namespace: {{ .Release.Namespace }}
 rules:
 - apiGroups: [""] # "" indicates the core API group
+{{- if .Values.routerSpec.k8sServiceDiscoveryType | default "pod-ip" | eq "pod-ip" }}
   resources: ["pods"]
-  verbs: ["get", "watch", "list", "patch"]
 {{- else }}
-apiVersion: rbac.authorization.k8s.io/v1
-kind: Role
-metadata:
-  name: "{{ .Release.Name }}-service-reader"
-  namespace: {{ .Release.Namespace }}
-rules:
-  - apiGroups: [ "" ] # "" indicates the core API group
-    resources: [ "services", "endpoints" ]
-    verbs: [ "get", "watch", "list", "patch" ]
+  resources: ["pods", "services", "endpoints"]
 {{- end }}
+  verbs: ["get", "watch", "list", "patch"]
 {{- end }}
 
 {{- if .Values.loraController.enableLoraController }}

helm/templates/rolebinding.yaml

@@ -1,5 +1,4 @@
 {{- if .Values.routerSpec.enableRouter -}}
-{{- if .Values.routerSpec.k8sServiceDiscoveryType | default "pod-ip" | eq "pod-ip" }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
@@ -11,23 +10,8 @@ subjects:
     namespace: {{ .Release.Namespace }}
 roleRef:
   kind: Role
-  name: {{ .Release.Name }}-pod-reader
+  name: {{ .Release.Name }}-reader
   apiGroup: rbac.authorization.k8s.io
-{{ else }}
-apiVersion: rbac.authorization.k8s.io/v1
-kind: RoleBinding
-metadata:
-  name: {{ .Release.Name }}-deployment-access-binding
-  namespace: {{ .Release.Namespace }}
-subjects:
-  - kind: ServiceAccount
-    name: {{ .Release.Name }}-router-service-account
-    namespace: {{ .Release.Namespace }}
-roleRef:
-  kind: Role
-  name: {{ .Release.Name }}-service-reader
-  apiGroup: rbac.authorization.k8s.io
-{{- end }}
 {{- end }}
 
 {{- if .Values.loraController.enableLoraController }}