Deprecate Maybe.Execute and Maybe.ExecuteNoValue

marcinjahn · marcinjahn · commit e365b3a08c58 · 2025-04-12T21:21:37.000+02:00
Maybe.Tap and Maybe.TapNoValue are able to take over the deprecated
methods with added functionality.
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/Execute.Task.Left.cs b/CSharpFunctionalExtensions/Maybe/Extensions/Execute.Task.Left.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Threading.Tasks;
 
 namespace CSharpFunctionalExtensions
@@ -12,6 +12,7 @@ public static partial class MaybeExtensions
         /// <param name="action"></param>
         /// <typeparam name="T"></typeparam>
         /// <returns></returns>
+        [Obsolete("Use TapValue instead")]
         public static async Task Execute<T>(this Task<Maybe<T>> maybeTask, Action<T> action)
         {
             var maybe = await maybeTask.DefaultAwait();
@@ -22,4 +23,4 @@ public static async Task Execute<T>(this Task<Maybe<T>> maybeTask, Action<T> act
             action(maybe.GetValueOrThrow());
         }
     }
-}
+}
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/Execute.Task.Right.cs b/CSharpFunctionalExtensions/Maybe/Extensions/Execute.Task.Right.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Threading.Tasks;
 
 namespace CSharpFunctionalExtensions
@@ -11,6 +11,7 @@ public static partial class MaybeExtensions
         /// <param name="maybe"></param>
         /// <param name="action"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapValue instead")]
         public static async Task Execute<T>(this Maybe<T> maybe, Func<T, Task> action)
         {
             if (maybe.HasNoValue)
@@ -19,4 +20,4 @@ public static async Task Execute<T>(this Maybe<T> maybe, Func<T, Task> action)
             await action(maybe.GetValueOrThrow()).DefaultAwait();
         }
     }
-}
+}
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/Execute.Task.cs b/CSharpFunctionalExtensions/Maybe/Extensions/Execute.Task.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Threading.Tasks;
 
 namespace CSharpFunctionalExtensions
@@ -12,6 +12,7 @@ public static partial class MaybeExtensions
         /// <param name="asyncAction"></param>
         /// <typeparam name="T"></typeparam>
         /// <returns></returns>
+        [Obsolete("Use TapValue instead")]
         public static async Task Execute<T>(this Task<Maybe<T>> maybeTask, Func<T, Task> asyncAction)
         {
             var maybe = await maybeTask.DefaultAwait();
@@ -22,4 +23,4 @@ public static async Task Execute<T>(this Task<Maybe<T>> maybeTask, Func<T, Task>
             await asyncAction(maybe.GetValueOrThrow()).DefaultAwait();
         } 
     }
-}
+}
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/Execute.ValueTask.Left.cs b/CSharpFunctionalExtensions/Maybe/Extensions/Execute.ValueTask.Left.cs
@@ -1,4 +1,4 @@
-﻿#if NET5_0_OR_GREATER
+#if NET5_0_OR_GREATER
 using System;
 using System.Threading.Tasks;
 
@@ -13,6 +13,7 @@ public static partial class MaybeExtensions
         /// <param name="action"></param>
         /// <typeparam name="T"></typeparam>
         /// <returns></returns>
+        [Obsolete("Use TapValue instead")]
         public static async Task Execute<T>(this ValueTask<Maybe<T>> maybeTask, Action<T> action)
         {
             var maybe = await maybeTask;
@@ -24,4 +25,4 @@ public static async Task Execute<T>(this ValueTask<Maybe<T>> maybeTask, Action<T
         }
     }
 }
-#endif
+#endif
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/Execute.ValueTask.Right.cs b/CSharpFunctionalExtensions/Maybe/Extensions/Execute.ValueTask.Right.cs
@@ -1,4 +1,4 @@
-﻿#if NET5_0_OR_GREATER
+#if NET5_0_OR_GREATER
 using System;
 using System.Threading.Tasks;
 
@@ -12,6 +12,7 @@ public static partial class MaybeExtensions
         /// <param name="maybe"></param>
         /// <param name="valueTask"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapValue instead")]
         public static async Task Execute<T>(this Maybe<T> maybe, Func<T, ValueTask> valueTask)
         {
             if (maybe.HasNoValue)
@@ -21,4 +22,4 @@ public static async Task Execute<T>(this Maybe<T> maybe, Func<T, ValueTask> valu
         }
     }
 }
-#endif
+#endif
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/Execute.ValueTask.cs b/CSharpFunctionalExtensions/Maybe/Extensions/Execute.ValueTask.cs
@@ -1,4 +1,4 @@
-﻿#if NET5_0_OR_GREATER
+#if NET5_0_OR_GREATER
 using System;
 using System.Threading.Tasks;
 
@@ -13,6 +13,7 @@ public static partial class MaybeExtensions
         /// <param name="valueTask"></param>
         /// <typeparam name="T"></typeparam>
         /// <returns></returns>
+        [Obsolete("Use TapValue instead")]
         public static async Task Execute<T>(this ValueTask<Maybe<T>> maybeTask, Func<T, ValueTask> valueTask)
         {
             var maybe = await maybeTask;
@@ -24,4 +25,4 @@ public static async Task Execute<T>(this ValueTask<Maybe<T>> maybeTask, Func<T,
         }
     }
 }
-#endif
+#endif
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/Execute.cs b/CSharpFunctionalExtensions/Maybe/Extensions/Execute.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 
 namespace CSharpFunctionalExtensions
 {
@@ -10,6 +10,7 @@ public static partial class MaybeExtensions
         /// <param name="maybe"></param>
         /// <param name="action"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapValue instead")]
         public static void Execute<T>(in this Maybe<T> maybe, Action<T> action)
         {
             if (maybe.HasNoValue)
@@ -18,4 +19,4 @@ public static void Execute<T>(in this Maybe<T> maybe, Action<T> action)
             action(maybe.GetValueOrThrow());
         }
     }
-}
+}
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.Task.Left.cs b/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.Task.Left.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Threading.Tasks;
 
 namespace CSharpFunctionalExtensions
@@ -11,6 +11,7 @@ public static partial class MaybeExtensions
         /// <param name="maybeTask"></param>
         /// <param name="action"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapNoValue instead")]
         public static async Task ExecuteNoValue<T>(this Task<Maybe<T>> maybeTask, Action action)
         {
             var maybe = await maybeTask.DefaultAwait();
@@ -21,4 +22,4 @@ public static async Task ExecuteNoValue<T>(this Task<Maybe<T>> maybeTask, Action
             action();
         }
     }
-}
+}
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.Task.Right.cs b/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.Task.Right.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Threading.Tasks;
 
 namespace CSharpFunctionalExtensions
@@ -11,6 +11,7 @@ public static partial class MaybeExtensions
         /// <param name="maybe"></param>
         /// <param name="action"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapNoValue instead")]
         public static async Task ExecuteNoValue<T>(this Maybe<T> maybe, Func<Task> action)
         {
             if (maybe.HasValue)
@@ -19,4 +20,4 @@ public static async Task ExecuteNoValue<T>(this Maybe<T> maybe, Func<Task> actio
             await action().DefaultAwait();
         }
     }
-}
+}
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.Task.cs b/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.Task.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Threading.Tasks;
 
 namespace CSharpFunctionalExtensions
@@ -11,6 +11,7 @@ public static partial class MaybeExtensions
         /// <param name="maybeTask"></param>
         /// <param name="asyncAction"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapNoValue instead")]
         public static async Task ExecuteNoValue<T>(this Task<Maybe<T>> maybeTask, Func<Task> asyncAction)
         {
             var maybe = await maybeTask.DefaultAwait();
@@ -21,4 +22,4 @@ public static async Task ExecuteNoValue<T>(this Task<Maybe<T>> maybeTask, Func<T
             await asyncAction().DefaultAwait();
         }
     }
-}
+}
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.ValueTask.Left.cs b/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.ValueTask.Left.cs
@@ -1,4 +1,4 @@
-﻿#if NET5_0_OR_GREATER
+#if NET5_0_OR_GREATER
 using System;
 using System.Threading.Tasks;
 
@@ -12,6 +12,7 @@ public static partial class MaybeExtensions
         /// <param name="maybeTask"></param>
         /// <param name="action"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapNoValue instead")]
         public static async Task ExecuteNoValue<T>(this ValueTask<Maybe<T>> maybeTask, Action action)
         {
             var maybe = await maybeTask;
@@ -23,4 +24,4 @@ public static async Task ExecuteNoValue<T>(this ValueTask<Maybe<T>> maybeTask, A
         }
     }
 }
-#endif
+#endif
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.ValueTask.Right.cs b/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.ValueTask.Right.cs
@@ -1,4 +1,4 @@
-﻿#if NET5_0_OR_GREATER
+#if NET5_0_OR_GREATER
 using System;
 using System.Threading.Tasks;
 
@@ -12,6 +12,7 @@ public static partial class MaybeExtensions
         /// <param name="maybe"></param>
         /// <param name="valueTask"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapNoValue instead")]
         public static async Task ExecuteNoValue<T>(this Maybe<T> maybe, Func<ValueTask> valueTask)
         {
             if (maybe.HasValue)
@@ -21,4 +22,4 @@ public static async Task ExecuteNoValue<T>(this Maybe<T> maybe, Func<ValueTask>
         }
     }
 }
-#endif
+#endif
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.ValueTask.cs b/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.ValueTask.cs
@@ -1,4 +1,4 @@
-﻿#if NET5_0_OR_GREATER
+#if NET5_0_OR_GREATER
 using System;
 using System.Threading.Tasks;
 
@@ -12,6 +12,7 @@ public static partial class MaybeExtensions
         /// <param name="maybeTask"></param>
         /// <param name="valueTask"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapNoValue instead")]
         public static async Task ExecuteNoValue<T>(this ValueTask<Maybe<T>> maybeTask, Func<ValueTask> valueTask)
         {
             var maybe = await maybeTask;
@@ -24,4 +25,4 @@ public static async Task ExecuteNoValue<T>(this ValueTask<Maybe<T>> maybeTask, F
 
     }
 }
-#endif
+#endif
diff --git a/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.cs b/CSharpFunctionalExtensions/Maybe/Extensions/ExecuteNoValue.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 
 namespace CSharpFunctionalExtensions
 {
@@ -10,6 +10,7 @@ public static partial class MaybeExtensions
         /// <param name="maybe"></param>
         /// <param name="action"></param>
         /// <typeparam name="T"></typeparam>
+        [Obsolete("Use TapNoValue instead")]
         public static void ExecuteNoValue<T>(in this Maybe<T> maybe, Action action)
         {
             if (maybe.HasValue)
@@ -18,4 +19,4 @@ public static void ExecuteNoValue<T>(in this Maybe<T> maybe, Action action)
             action();
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-using System;`
	`1`	`+using System;`
`2`	`2`	`using System.Threading.Tasks;`
`3`	`3`
`4`	`4`	`namespace CSharpFunctionalExtensions`
`@@ -12,6 +12,7 @@ public static partial class MaybeExtensions`
`12`	`12`	`/// <param name="action"></param>`
`13`	`13`	`/// <typeparam name="T"></typeparam>`
`14`	`14`	`/// <returns></returns>`
	`15`	`+ [Obsolete("Use TapValue instead")]`
`15`	`16`	`public static async Task Execute<T>(this Task<Maybe<T>> maybeTask, Action<T> action)`
`16`	`17`	`{`
`17`	`18`	`var maybe = await maybeTask.DefaultAwait();`
`@@ -22,4 +23,4 @@ public static async Task Execute<T>(this Task<Maybe<T>> maybeTask, Action<T> act`
`22`	`23`	`action(maybe.GetValueOrThrow());`
`23`	`24`	`}`
`24`	`25`	`}`
`25`		`-}`
	`26`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-#if NET5_0_OR_GREATER`
	`1`	`+#if NET5_0_OR_GREATER`
`2`	`2`	`using System;`
`3`	`3`	`using System.Threading.Tasks;`
`4`	`4`
`@@ -13,6 +13,7 @@ public static partial class MaybeExtensions`
`13`	`13`	`/// <param name="action"></param>`
`14`	`14`	`/// <typeparam name="T"></typeparam>`
`15`	`15`	`/// <returns></returns>`
	`16`	`+ [Obsolete("Use TapValue instead")]`
`16`	`17`	`public static async Task Execute<T>(this ValueTask<Maybe<T>> maybeTask, Action<T> action)`
`17`	`18`	`{`
`18`	`19`	`var maybe = await maybeTask;`
`@@ -24,4 +25,4 @@ public static async Task Execute<T>(this ValueTask<Maybe<T>> maybeTask, Action<T`
`24`	`25`	`}`
`25`	`26`	`}`
`26`	`27`	`}`
`27`		`-#endif`
	`28`	`+#endif`