Skip to content

Commit 59907f8

Browse files
authored
Merge pull request #55 from veghdev/doc
doc: refactor, set doc versioning
2 parents ee8d766 + 5b59185 commit 59907f8

File tree

98 files changed

+60228
-16807
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+60228
-16807
lines changed

.github/workflows/ci.yml

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,36 @@ jobs:
1818

1919
- uses: actions/cache@v3
2020
with:
21-
path: ./.venv-ipyvizzu-story
22-
key: venv-${{ inputs.run_id }}
21+
path: ./.venv_ipyvizzu_story
22+
key: venv-ipyvizzu-story-${{ inputs.run_id }}
23+
24+
- uses: actions/cache@v3
25+
with:
26+
path: ./node_modules
27+
key: nodemodules-ipyvizzu-story-${{ github.run_id }}
2328

2429
- uses: actions/cache@v3
2530
with:
2631
path: ./tests/coverage
27-
key: coverage-${{ inputs.run_id }}
32+
key: coverage-ipyvizzu-story-${{ inputs.run_id }}
2833

2934
- name: Touch dev environment
3035
run: make touch-dev
36+
37+
- name: Touch dev-js environment
38+
run: make touch-dev-js
3139

3240
- name: Check format
3341
run: make check-format
3442

35-
- name: Run pylint
36-
run: make lint
43+
- name: Check lint
44+
run: make check-lint
3745

3846
- name: Check typing
3947
run: make check-typing
4048

4149
- name: Run test
4250
run: make test
51+
52+
- name: Check js
53+
run: make check-js

.github/workflows/cicd.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,15 @@ jobs:
2121
with:
2222
run_id: ${{ github.run_id }}
2323

24-
doc_build:
25-
uses: ./.github/workflows/doc_build.yml
24+
doc:
25+
uses: ./.github/workflows/doc.yml
2626
needs: ci
2727
with:
2828
run_id: ${{ github.run_id }}
2929

30-
doc_publish:
31-
uses: ./.github/workflows/doc_publish.yml
32-
needs: doc_build
33-
with:
34-
run_id: ${{ github.run_id }}
35-
3630
release:
3731
uses: ./.github/workflows/release.yml
3832
secrets: inherit
39-
needs: doc_build
33+
needs: doc
4034
with:
4135
run_id: ${{ github.run_id }}

.github/workflows/doc_build.yml renamed to .github/workflows/doc.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,25 @@ jobs:
1717

1818
- uses: actions/cache@v3
1919
with:
20-
path: ./.venv-ipyvizzu-story
21-
key: venv-${{ inputs.run_id }}
20+
path: ./.venv_ipyvizzu_story
21+
key: venv-ipyvizzu-story-${{ inputs.run_id }}
2222

2323
- uses: actions/cache@v3
2424
with:
25-
path: ./tests/coverage
26-
key: coverage-${{ inputs.run_id }}
25+
path: ./node_modules
26+
key: nodemodules-ipyvizzu-story-${{ github.run_id }}
2727

2828
- uses: actions/cache@v3
2929
with:
30-
path: ./site
31-
key: site-${{ inputs.run_id }}
30+
path: ./tests/coverage
31+
key: coverage-ipyvizzu-story-${{ inputs.run_id }}
3232

3333
- name: Touch dev environment
3434
run: make touch-dev
3535

36+
- name: Touch dev-js environment
37+
run: make touch-dev-js
38+
3639
- name: Set Jupyter kernel
3740
run: make install-kernel
3841

.github/workflows/doc_publish.yml

Lines changed: 0 additions & 75 deletions
This file was deleted.

.github/workflows/init.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,16 @@ jobs:
1818

1919
- uses: actions/cache@v3
2020
with:
21-
path: ./.venv-ipyvizzu-story
22-
key: venv-${{ inputs.run_id }}
21+
path: ./.venv_ipyvizzu_story
22+
key: venv-ipyvizzu-story-${{ inputs.run_id }}
23+
24+
- uses: actions/cache@v3
25+
with:
26+
path: ./node_modules
27+
key: nodemodules-ipyvizzu-story-${{ github.run_id }}
2328

2429
- name: Init dev environment
25-
run: make dev
30+
run: make dev
31+
32+
- name: Init dev-js environment
33+
run: make dev-js

.github/workflows/release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,17 @@ jobs:
1818

1919
- uses: actions/cache@v3
2020
with:
21-
path: ./.venv-ipyvizzu-story
22-
key: venv-${{ inputs.run_id }}
21+
path: ./.venv_ipyvizzu_story
22+
key: venv-ipyvizzu-story-${{ inputs.run_id }}
2323

2424
- name: Touch dev environment
2525
run: make touch-dev
2626

2727
- name: Build package
28-
run: make release
28+
run: make release-wo-restore
2929

3030
- name: Release package
31-
run: ./.venv-ipyvizzu-story/bin/python -m twine upload -u "__token__" -p "${{ secrets.PYPI_API_TOKEN }}" dist/*.tar.gz dist/*.whl
31+
run: ./.venv_ipyvizzu_story/bin/python -m twine upload -u "__token__" -p "${{ secrets.PYPI_API_TOKEN }}" dist/*.tar.gz dist/*.whl
3232
if: ( github.event_name == 'release' && github.event.action == 'published' )
3333

3434
- name: Upload package

.github/workflows/site.yml

Lines changed: 0 additions & 15 deletions
This file was deleted.

.gitignore

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@ build
77
dist
88
*.egg-info
99

10-
coverage
10+
tests/coverage
1111
.test.*
1212

13-
.venv
14-
.venv-ipyvizzu-story
13+
.venv_ipyvizzu_story
1514

1615
site
1716
node_modules
18-
package-lock.json
17+
package-lock.json

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ repos:
2121
types: [python]
2222
pass_filenames: false
2323

24-
- id: lint
24+
- id: check-lint
2525
stages: [push]
26-
name: lint
26+
name: check-lint
2727
entry: make
28-
args: ["lint"]
28+
args: ["check-lint"]
2929
language: system
3030
types: [python]
3131
pass_filenames: false

CONTRIBUTING.md

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ detailed description of how to do this in
1717

1818
### Development environment
1919

20-
You can initialize the development environment of ipyvizzu-story with python
20+
You can initialize the development environment of `ipyvizzu-story` with `Python`
2121
virtual env.
2222

2323
Run the `dev` make target to set up your environment.
@@ -26,10 +26,6 @@ Run the `dev` make target to set up your environment.
2626
make dev
2727
```
2828

29-
**Note:** If you are using Windows, you need to install `GNU make` to use `make`
30-
commands. If you are using `Chocolatey`, you can easily install it with
31-
`choco install make`.
32-
3329
**Note:** The `dev` make target is going to set up pre-commit and pre-push hooks
3430
into your local git repository. Pre-commit hook is going to format the code with
3531
`black` and pre-push hook is going to run the CI steps.
@@ -43,7 +39,7 @@ make clean
4339
### CI
4440

4541
The CI steps check code formatting, run code analyses, check typing and run unit
46-
tests over the ipyvizzu-story project.
42+
tests over the `ipyvizzu-story` project.
4743

4844
The `check` make target collects the above tasks. Run the `check` make target to
4945
run the CI steps.
@@ -54,7 +50,7 @@ make check
5450

5551
#### Formatting
5652

57-
The ipyvizzu-story project is formatted with `black`.
53+
The `ipyvizzu-story` project is formatted with `black`.
5854

5955
Run the `format` make target to format your code.
6056

@@ -70,17 +66,17 @@ make check-format
7066

7167
#### Code analyses
7268

73-
The ipyvizzu-story project is analysed with `pylint`.
69+
The `ipyvizzu-story` project is analysed with `pylint`.
7470

75-
Run the `lint` make target to run code analyses.
71+
Run the `check-lint` make target to run code analyses.
7672

7773
```sh
78-
make lint
74+
make check-lint
7975
```
8076

8177
#### Typing
8278

83-
The ipyvizzu-story project is using type hints.
79+
The `ipyvizzu-story` project is using type hints.
8480

8581
Run the `check-typing` make target to run check code typing.
8682

@@ -90,9 +86,9 @@ make check-typing
9086

9187
#### Testing
9288

93-
The ipyvizzu-story project is tested with `unittest` testing framework.
89+
The `ipyvizzu-story` project is tested with `unittest` testing framework.
9490

95-
Run the `test` make target to install ipyvizzu-story into your virtual
91+
Run the `test` make target to install `ipyvizzu-story` into your virtual
9692
environment and run the tests.
9793

9894
```sh
@@ -103,21 +99,27 @@ make test
10399

104100
Run the `doc` make target to build the documentation.
105101

102+
Note: If you modify the documentation, you also need to configure the
103+
`JavaScript` development environment.
104+
106105
```sh
106+
make dev-js
107+
108+
make check-js
109+
107110
make doc
108111
```
109112

110-
The documentation will be published to the gh-pages branch with the `doc`
111-
workflow. Online version can be read at
112-
[ipyvizzu-story.vizzuhq.com](https://ipyvizzu-story.vizzuhq.com).
113+
Online version can be read at
114+
[ipyvizzu-story.vizzuhq.com](https://ipyvizzu-story.vizzuhq.com/latest/).
113115

114116
### Release
115117

116-
ipyvizzu-story is distributed on
118+
`ipyvizzu-story` is distributed on
117119
[pypi](https://pypi.org/project/ipyvizzu-story). **Note:** You need to be an
118120
administrator to release the project.
119121

120-
If you want to release ipyvizzu-story follow the steps below.
122+
If you want to release `ipyvizzu-story` follow the steps below.
121123

122124
- You should increase the version number in `setup.py`. The version bump should
123125
be in a separated commit.
@@ -126,7 +128,7 @@ If you want to release ipyvizzu-story follow the steps below.
126128
[Releases](https://github.com/vizzuhq/ipyvizzu-story/releases).
127129

128130
**Note:** Publishing a new release will automatically trigger the `release`
129-
workflow which builds, checks and uploads the ipyvizzu-story package to
131+
workflow which builds, checks and uploads the `ipyvizzu-story` package to
130132
[pypi](https://pypi.org/project/ipyvizzu-story).
131133

132134
You can build and check the package before a release with the `release` make

0 commit comments

Comments
 (0)