Skip to content

Commit 13838b5

Browse files
author
Stefanie Kaltenhauser
committed
Review: Remove image layout shift workaround
1 parent e116fe6 commit 13838b5

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

demo/site/src/common/blocks/TextImageBlock.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ import styled, { css } from "styled-components";
88
import { DamImageBlock } from "./DamImageBlock";
99
import { RichTextBlock } from "./RichTextBlock";
1010

11-
const TextImageBlock = withPreview(
11+
export const TextImageBlock = withPreview(
1212
({ data: { text, image, imageAspectRatio, imagePosition } }: PropsWithData<TextImageBlockData>) => {
1313
return (
1414
<Root $imagePosition={imagePosition}>
15-
<ImageContainer $imageAspectRatio={imageAspectRatio.replace("x", "/")}>
16-
<DamImageBlock data={image} aspectRatio={imageAspectRatio} fill sizes={createImageSizes({ xs: "100vw", md: "30vw" })} />
15+
<ImageContainer>
16+
<DamImageBlock data={image} aspectRatio={imageAspectRatio} sizes={createImageSizes({ xs: "100vw", md: "30vw" })} />
1717
</ImageContainer>
1818
<TextContainer>
1919
<RichTextBlock data={text} />
@@ -46,10 +46,8 @@ const Root = styled.div<{ $imagePosition: TextImageBlockData["imagePosition"] }>
4646
`}
4747
`;
4848

49-
const ImageContainer = styled.div<{ $imageAspectRatio: TextImageBlockData["imageAspectRatio"] }>`
50-
position: relative;
49+
const ImageContainer = styled.div`
5150
flex: 1;
52-
aspect-ratio: ${({ $imageAspectRatio }) => $imageAspectRatio};
5351
`;
5452

5553
const TextContainer = styled.div`

0 commit comments

Comments
 (0)