Pratham Sood Firmware Training Oct 2021 #399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindyli-13
requested changes
Oct 11, 2021
Member
cindyli-13
left a comment
cindyli-13
left a comment
There was a problem hiding this comment.
Your training mostly looks good! Just some minor fixes needed
|
|
||
| add_library (TutorialServo STATIC) | ||
| target_sources (TutorialServo PRIVATE src/TutorialServo.cpp) | ||
| target_link_libraries (tutorial-servo-can-control PRIVATE |
Member
There was a problem hiding this comment.
You shouldn't need this line since it's repeated in line 12
| } | ||
|
|
||
| void TutorialServo::setPositionInDegrees( const float degrees){ | ||
| if (degrees >= m_servoRangeInDegrees && degrees >= 0) |
Member
There was a problem hiding this comment.
Suggested change
| if (degrees >= m_servoRangeInDegrees && degrees >= 0) | |
| if (degrees <= m_servoRangeInDegrees && degrees >= 0) |
Member
|
Make sure to also follow the "Clang-Format" section of the readme and format your files |
cindyli-13
requested changes
Oct 20, 2021
Member
cindyli-13
left a comment
cindyli-13
left a comment
There was a problem hiding this comment.
There's just one small issue, but everything else looks good. Were you able apply clang format?
| void TutorialServo::setPositionInDegrees( const float degrees){ | ||
| if (degrees <= m_servoRangeInDegrees && degrees >= 0) | ||
| { | ||
| m_servoPwmOut.pulsewidth((degrees/m_servoRangeInDegrees)*(m_maxPulsewidthInMs-m_minPulsewidthInMs)); |
Member
There was a problem hiding this comment.
what if m_minPulsewidthInMs is nonzero? you'll need the constant offset so that 0 degrees maps to m_minPulsewidthInMs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.