-
Notifications
You must be signed in to change notification settings - Fork 51
React 18 compatibility #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @derwaldgeist, Unfortunately, this package is not actively maintained at the moment. However, if there haven’t been breaking changes in the React 18 API that affect its core functionality, it should still work. To help investigate this issue further, I would appreciate reproducible test cases that clearly demonstrate the problem. This will allow me and/or the community to better understand the issue and find potential fixes. Additionally, contributions that help with migrating this package to the latest React version are highly welcome! If you’re interested in helping, feel free to open a PR. Thanks again! |
Thanks for your feedback! I asked ChatGPT yesterday what the actual changes are when you use the new way of mounting. It said that this enables the performance optimizations of React 18, which might cause asynchronous updates, different order of effects and different timings. I guess that's the case here. I can try to provide a reproduction repo, but it will be tough because the map is deeply embedded in our app and loads its content dynamically. Do you plan to pickup maintenance of this package in the future again? I love that it enables to use other tiling services than Mapbox (which are pretty expensive). Im using Maptiler and am pretty happy with the combo. |
Yeah, I totally get that extracting a minimal reproduction might be tough in a complex app. If you do manage to put something together, that would be really helpful. As for maintenance, I don’t have plans to fully pick this up again, unfortunately. I might work on minor things when I have some spare time, but it’s not a high priority for me at the moment. That said, I’d be happy to review and merge PRs if the community is willing to contribute. Appreciate your support, and I’m glad to hear you’re finding the package useful 🙏 |
I am currently porting my React 17 app to React 18 and noticed that the maps behave a bit weird as soon as a activate the new way of mounting the app to the DOM (createRoot vs. render), i.e. when leaving the React 17 compatibility mode. The most noticable effects are that markers are "stuttering" (appearing and disappearing in quick succession), and marker clusters re-render pretty often.
Since I am using the latest version of this library, I am wondering if there are plans to support React 18 as well, or maybe there is a work-around for these issues?
Thanks for the great work!
The text was updated successfully, but these errors were encountered: