Add support for numeric timestamps on DateAssert

Author: Joao Madeiras

src/asserts/date-assert.js

@@ -21,12 +21,24 @@ export default function dateAssert() {
    */
 
   this.validate = value => {
-    if (typeof value !== 'string' && Object.prototype.toString.call(value) !== '[object Date]') {
-      throw new Violation(this, value, { value: 'must_be_a_date_or_a_string' });
+    if (typeof value === 'string') {
+      if (isNaN(Date.parse(value))) {
+        throw new Violation(this, value);
+      }
+
+      return true;
+    }
+
+    if (typeof value === 'number') {
+      if (isNaN(new Date(value)) || new Date(value).getTime() < 0) {
+        throw new Violation(this, value);
+      }
+
+      return true;
     }
 
-    if (isNaN(Date.parse(value)) === true) {
-      throw new Violation(this, value);
+    if (!(value instanceof Date) && Object.prototype.toString.call(value) !== '[object Date]') {
+      throw new Violation(this, value, { value: 'must_be_a_date_or_a_string_or_a_number' });
     }
 
     return true;

test/asserts/date-assert_test.js

@@ -20,8 +20,8 @@ const Assert = BaseAssert.extend({
  */
 
 describe('DateAssert', () => {
-  it('should throw an error if the input value is not a string or a date', () => {
-    const choices = [[], {}, 123];
+  it('should throw an error if the input value is not a date or a string or a timestamp', () => {
+    const choices = [[], {}];
 
     choices.forEach(choice => {
       try {
@@ -30,11 +30,21 @@ describe('DateAssert', () => {
         should.fail();
       } catch (e) {
         e.should.be.instanceOf(Violation);
-        e.violation.value.should.equal('must_be_a_date_or_a_string');
+        e.violation.value.should.equal('must_be_a_date_or_a_string_or_a_number');
       }
     });
   });
 
+  it('should throw an error if the input value is an invalid timestamp', () => {
+    try {
+      new Assert().Date().validate(-Number.MAX_VALUE);
+
+      should.fail();
+    } catch (e) {
+      e.should.be.instanceOf(Violation);
+    }
+  });
+
   it('should expose `assert` equal to `Date`', () => {
     try {
       new Assert().Date().validate('foo');
@@ -45,11 +55,19 @@ describe('DateAssert', () => {
     }
   });
 
-  it('should accept a `Date`', () => {
+  it('should accept an instance of `Date`', () => {
     new Assert().Date().validate(new Date());
   });
 
-  it('should accept a `string`', () => {
-    new Assert().Date().validate('2014-10-16');
+  it('should accept a string date', () => {
+    new Assert().Date().validate('2016-04-23');
+  });
+
+  it('should accept an ISO-8601 string date', () => {
+    new Assert().Date().validate('2016-04-23T00:51:18.570Z');
+  });
+
+  it('should accept a numeric timestamp', () => {
+    new Assert().Date().validate(Date.now());
   });
 });