Skip to content

Commit 095037b

Browse files
committed
fix: fixes to number-input/url-input
1 parent d539e4e commit 095037b

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

addon/components/o-s-s/number-input.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<OSS::Button @square={{true}} @size="md" @icon="far fa-minus" {{on "click" this.decreaseValue}}
33
disabled={{or this.isMinDisabled @disabled}} {{enable-tooltip title=this.minTooltipTitle placement="top"}} />
44
{{! template-lint-disable no-triple-curlies}}
5-
<OSS::InputContainer @value={{this.localValue}} @onChange={{this.checkUserInput}} @disabled={{@disabled}} style={{{this.dynamicWidth}}}
5+
<OSS::InputContainer @value={{this.localValue}} @onChange={{fn this.checkUserInput}} @disabled={{@disabled}} style={{{this.dynamicWidth}}}
66
{{on "keydown" this.keyParser}} {{on "blur" this.checkUserInput}}
77
{{did-insert this.registerInputElement}} />
88
<OSS::Button @square={{true}} @size="md" @icon="far fa-plus" {{on "click" this.increaseValue}}

addon/components/o-s-s/number-input.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,12 @@ export default class OSSNumberInput extends Component<OSSNumberInputArgs> {
7474
}
7575

7676
@action
77-
checkUserInput(): void {
77+
checkUserInput(value?: string): void {
78+
// If value is provided, update localValue first
79+
if (value !== undefined) {
80+
this.localValue = Number(value);
81+
}
82+
7883
if (this.args.min !== undefined && Number(this.localValue) < this.args.min) {
7984
this.localValue = this.args.min;
8085
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<OSS::InputGroup @value={{@value}} @prefix={{@prefix}} @suffix={{@suffix}}
22
@placeholder={{@placeholder}} @errorMessage={{this.errorLabel}}
3-
@onChange={{this.onInputChanged}} @disabled={{@disabled}} ...attributes />
3+
@onChange={{action this.onInputChanged}} @disabled={{@disabled}} ...attributes />

tests/integration/components/o-s-s/url-input-test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ module('Integration | Component | o-s-s/url-input', function (hooks) {
2828
@validationRegex={{this.subdomainRegex}} />`);
2929
await fillIn('input', 'fakedomai');
3030
await typeIn('input', 'n');
31-
assert.true(this.onChange.calledOnceWithExactly('fakedomain', true));
31+
assert.true(this.onChange.lastCall.calledWith('fakedomain', true));
3232
});
3333

3434
module("When the text doesn't match the Regex", () => {

0 commit comments

Comments
 (0)