fix(ThemeService): Only save theme on explicit user action #2913
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
review |
Author
|
merge approve |
kazo0
reviewed
Nov 12, 2025
| { | ||
| try | ||
| { | ||
| _settings.Set(CurrentThemeSettingsKey, theme.ToString()); |
Contributor
There was a problem hiding this comment.
What's the reason for removing this line and leaving an empty try block
|
|
||
| // Make sure initialization completes before attempting to set new theme | ||
| await _initialization.Task; | ||
| if (theme != AppTheme.System) |
Contributor
There was a problem hiding this comment.
We would still need the await _initialization.Task here, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2842
PR Type
What is the current behavior?
When the application is set to follow the system theme, any change in the system's theme (e.g., from Light to Dark) causes the
ThemeServiceto save the resolved theme ("Dark") to the settings file. This locks the application to that specific theme and prevents it from following any subsequent system theme changes.What is the new behavior?
This change moves the theme-saving logic from the internal theme-changed handler (
InternalSetThemeOnUIThread) to the publicSetThemeAsyncmethod.This ensures that the theme preference is only saved to settings when a user explicitly calls
SetThemeAsyncwith a specific theme (Light or Dark). The application now correctly follows the system theme by default without writing to the settings file, which resolves the original issue.PR Checklist
Screenshots Compare Test Runresults.