Skip to content

Commit 8c3fdfe

Browse files
committed
Merge branch 'master' of https://github.com/unitycontainer/container into v5.x
2 parents 982a768 + 8ea8e91 commit 8c3fdfe

File tree

8 files changed

+56
-27
lines changed

8 files changed

+56
-27
lines changed

src/Extensions/DiagnosticExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public static class DiagnosticExtensions
1212
/// <para>This extension method adds <see cref="Diagnostic"/> extension to the
1313
/// container and enables extended validation for all container's operations.</para>
1414
/// <para>This method will only work if the calling code is built with DEBUG
15-
/// symbol defined. In other word in you building in Debug mode. Condigional
15+
/// symbol defined. In other word in you building in Debug mode. Conditional
1616
/// methods can not return any values, so fluent notation can not be used with
1717
/// this method.</para>
1818
/// </remarks>
@@ -39,7 +39,7 @@ public static void EnableDebugDiagnostic(this UnityContainer container)
3939
/// <remarks>
4040
/// <para>This extension method adds <see cref="Diagnostic"/> extension to the
4141
/// container and enables extended validation for all container's operations.</para>
42-
/// <para>This method works regardles of build mode. In other word, it will
42+
/// <para>This method works regardless of the build mode. In other word, it will
4343
/// always enable validation. This method could be used with fluent notation.</para>
4444
/// </remarks>
4545
/// <example>

src/Strategies/BuildPlanStrategy.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ public override bool RequiredToBuildType(IUnityContainer container, Type type, I
4141
public override void PreBuildUp(ref BuilderContext context)
4242
{
4343
// Get resolver if already created
44-
var resolver = context.Registration.Get<ResolveDelegate<BuilderContext>>();
44+
var resolver = context.Registration.Get<ResolveDelegate<BuilderContext>>() ?? (ResolveDelegate<BuilderContext>)
45+
GetGeneric(ref context, typeof(ResolveDelegate<BuilderContext>));
46+
4547
if (null == resolver)
4648
{
4749
// Check if can create at all
@@ -59,9 +61,9 @@ public override void PreBuildUp(ref BuilderContext context)
5961

6062
// Get resolver factory
6163
var factory = context.Registration.Get<ResolveDelegateFactory>() ?? (ResolveDelegateFactory)(
62-
context.Get(context.Type, UnityContainer.All, typeof(ResolveDelegateFactory)) ??
63-
GetGeneric(ref context, typeof(ResolveDelegateFactory)) ??
64-
context.Get(null, null, typeof(ResolveDelegateFactory)));
64+
context.Get(context.Type, UnityContainer.All, typeof(ResolveDelegateFactory)) ??
65+
GetGeneric(ref context, typeof(ResolveDelegateFactory)) ??
66+
context.Get(null, null, typeof(ResolveDelegateFactory)));
6567

6668
// Create plan
6769
if (null != factory)

tests/Unity.Diagnostic/BuildUp.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
using Microsoft.VisualStudio.TestTools.UnitTesting;
22
using Unity;
3-
using Unity.Extension;
43

5-
namespace Compiled.BuildUp
4+
namespace Compiled
65
{
76
[TestClass]
8-
public class Validation : Unity.Specification.Diagnostic.BuildUp.SpecificationTests
7+
public class BuildUp : Unity.Specification.Diagnostic.BuildUp.SpecificationTests
98
{
109
public override IUnityContainer GetContainer()
1110
{
@@ -15,10 +14,10 @@ public override IUnityContainer GetContainer()
1514
}
1615
}
1716

18-
namespace Resolved.BuildUp
17+
namespace Resolved
1918
{
2019
[TestClass]
21-
public class Validation : Unity.Specification.Diagnostic.BuildUp.SpecificationTests
20+
public class BuildUp : Unity.Specification.Diagnostic.BuildUp.SpecificationTests
2221
{
2322
public override IUnityContainer GetContainer()
2423
{

tests/Unity.Diagnostic/Exceptions.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
using Microsoft.VisualStudio.TestTools.UnitTesting;
22
using Unity;
3-
using Unity.Extension;
43

5-
namespace Compiled.Exceptions
4+
namespace Compiled
65
{
76

87
[TestClass]
@@ -16,7 +15,7 @@ public override IUnityContainer GetContainer()
1615
}
1716
}
1817

19-
namespace Resolved.Exceptions
18+
namespace Resolved
2019
{
2120

2221
[TestClass]

tests/Unity.Diagnostic/Field.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
using Unity;
33
using Unity.Extension;
44

5-
namespace Compiled.Field
5+
namespace Compiled
66
{
77

88
[TestClass]
9-
public class Validation : Unity.Specification.Diagnostic.Field.Validation.SpecificationTests
9+
public class Field : Unity.Specification.Diagnostic.Field.Validation.SpecificationTests
1010
{
1111
public override IUnityContainer GetContainer()
1212
{
@@ -16,11 +16,11 @@ public override IUnityContainer GetContainer()
1616
}
1717
}
1818

19-
namespace Resolved.Field
19+
namespace Resolved
2020
{
2121

2222
[TestClass]
23-
public class Validation : Unity.Specification.Diagnostic.Field.Validation.SpecificationTests
23+
public class Field : Unity.Specification.Diagnostic.Field.Validation.SpecificationTests
2424
{
2525
public override IUnityContainer GetContainer()
2626
{

tests/Unity.Diagnostic/Hierarchical.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
using Microsoft.VisualStudio.TestTools.UnitTesting;
22
using Unity;
33

4-
namespace Compiled.Hierarchical
4+
namespace Compiled
55
{
66
[TestClass]
7-
public class Container : Unity.Specification.Diagnostic.Hierarchical.SpecificationTests
7+
public class Hierarchical : Unity.Specification.Diagnostic.Hierarchical.SpecificationTests
88
{
99
public override IUnityContainer GetContainer()
1010
{
@@ -14,10 +14,10 @@ public override IUnityContainer GetContainer()
1414
}
1515
}
1616

17-
namespace Resolved.Hierarchical
17+
namespace Resolved
1818
{
1919
[TestClass]
20-
public class Container : Unity.Specification.Diagnostic.Hierarchical.SpecificationTests
20+
public class Hierarchical : Unity.Specification.Diagnostic.Hierarchical.SpecificationTests
2121
{
2222
public override IUnityContainer GetContainer()
2323
{

tests/Unity.Diagnostic/Override.cs

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
using Microsoft.VisualStudio.TestTools.UnitTesting;
2+
using Unity;
3+
4+
namespace Compiled
5+
{
6+
7+
[TestClass]
8+
public class Override : Unity.Specification.Diagnostic.Override.SpecificationTests
9+
{
10+
public override IUnityContainer GetContainer()
11+
{
12+
return new UnityContainer(UnityContainer.BuildStrategy.Compiled)
13+
.AddExtension(new Diagnostic());
14+
}
15+
}
16+
}
17+
18+
namespace Resolved
19+
{
20+
21+
[TestClass]
22+
public class Override : Unity.Specification.Diagnostic.Override.SpecificationTests
23+
{
24+
public override IUnityContainer GetContainer()
25+
{
26+
return new UnityContainer(UnityContainer.BuildStrategy.Resolved)
27+
.AddExtension(new Diagnostic());
28+
}
29+
}
30+
}

tests/Unity.Diagnostic/Property.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
using Microsoft.VisualStudio.TestTools.UnitTesting;
22
using Unity;
3-
using Unity.Extension;
43

5-
namespace Compiled.Property
4+
namespace Compiled
65
{
76

87
[TestClass]
9-
public class Validation : Unity.Specification.Diagnostic.Property.Validation.SpecificationTests
8+
public class Property : Unity.Specification.Diagnostic.Property.Validation.SpecificationTests
109
{
1110
public override IUnityContainer GetContainer()
1211
{
@@ -16,11 +15,11 @@ public override IUnityContainer GetContainer()
1615
}
1716
}
1817

19-
namespace Resolved.Property
18+
namespace Resolved
2019
{
2120

2221
[TestClass]
23-
public class Validation : Unity.Specification.Diagnostic.Property.Validation.SpecificationTests
22+
public class Property : Unity.Specification.Diagnostic.Property.Validation.SpecificationTests
2423
{
2524
public override IUnityContainer GetContainer()
2625
{

0 commit comments

Comments
 (0)