UY-1453 fix state in error handling

ppiernik · ppiernik · commit 41aba38560ab · 2024-06-12T18:58:05.000+02:00
diff --git a/oauth/src/main/java/pl/edu/icm/unity/oauth/as/webauthz/OAuthAuthzWebEndpoint.java b/oauth/src/main/java/pl/edu/icm/unity/oauth/as/webauthz/OAuthAuthzWebEndpoint.java
@@ -27,6 +27,7 @@
 
 import com.nimbusds.oauth2.sdk.AuthorizationErrorResponse;
 import com.nimbusds.oauth2.sdk.SerializeException;
+import com.nimbusds.oauth2.sdk.id.State;
 import com.nimbusds.openid.connect.sdk.OIDCError;
 
 import eu.unicore.util.configuration.ConfigurationException;
@@ -234,7 +235,7 @@ private void returnOAuthError(HttpServletRequest request, HttpServletResponse re
 		{
 			OAuthAuthzContext ctx = OAuthSessionService.getContext(request).get();
 			AuthorizationErrorResponse oauthResponse = new AuthorizationErrorResponse(ctx.getReturnURI(),
-					OIDCError.LOGIN_REQUIRED, ctx.getRequest().getState(),
+					OIDCError.LOGIN_REQUIRED,  State.parse(request.getParameter("state")),
 					ctx.getRequest().impliedResponseMode());
 			try
 			{

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@`
`27`	`27`
`28`	`28`	`import com.nimbusds.oauth2.sdk.AuthorizationErrorResponse;`
`29`	`29`	`import com.nimbusds.oauth2.sdk.SerializeException;`
	`30`	`+import com.nimbusds.oauth2.sdk.id.State;`
`30`	`31`	`import com.nimbusds.openid.connect.sdk.OIDCError;`
`31`	`32`
`32`	`33`	`import eu.unicore.util.configuration.ConfigurationException;`
`@@ -234,7 +235,7 @@ private void returnOAuthError(HttpServletRequest request, HttpServletResponse re`
`234`	`235`	`{`
`235`	`236`	`OAuthAuthzContext ctx = OAuthSessionService.getContext(request).get();`
`236`	`237`	`AuthorizationErrorResponse oauthResponse = new AuthorizationErrorResponse(ctx.getReturnURI(),`
`237`		`- OIDCError.LOGIN_REQUIRED, ctx.getRequest().getState(),`
	`238`	`+ OIDCError.LOGIN_REQUIRED, State.parse(request.getParameter("state")),`
`238`	`239`	`ctx.getRequest().impliedResponseMode());`
`239`	`240`	`try`
`240`	`241`	`{`