Subsequent feature: Modularized asm IO as proposed in scalismo #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsendennis
reviewed
Feb 4, 2024
| * limitations under the License. | ||
| */ | ||
| package scalismo.asm.io | ||
| package scalismo.io |
Collaborator
There was a problem hiding this comment.
So far everything in scalismo-asm is in the scalismo.asm. package. Same for vtk. We can also change it everywhere to be part of scalismo itself as that would make less changes for people updating from scalismo 0.x.
Just need to be consistent.
madsendennis
approved these changes
Feb 4, 2024
Collaborator
madsendennis
left a comment
madsendennis
left a comment
There was a problem hiding this comment.
Beside the comment, looks good to me.
marcelluethi
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the same concept for providing an additional method to write models to a specific path. The same way as it is in an currently open PR in scalismo.
As this PR is based on scalismo PR 425, it should not be merged before.