Migrate to TypeDB HTTP API, new add-parent-group functionality #6
Conversation
whummer
left a comment
whummer
left a comment
There was a problem hiding this comment.
Looks awesome - great set of changes @flyingsilverfin ! 🚀
I checked out the branch locally and deployed the app - worked smoothly. 👌
Only added a minor comment - perhaps we could make the driver configurable? (but could also be tackled in a future iteration.. 👍 )
| from typedb.driver import ( | ||
| TypeDB, | ||
| from typedb_http_driver import ( | ||
| TypeDBHttpDriver, |
There was a problem hiding this comment.
nit: would be great if we could make the driver configurable, to make it easy to switch between different implementations (e.g., via an environment variable configured for the Lambda function).
Shouldn't be a blocker here, but would be a nice addition to simplify testing different drivers.. 👍
There was a problem hiding this comment.
Yeah to be honest I've been wondering why i can't reproduce this in any other way. I wonder if it's something with Docker not doing so well with HTTP streaming or something! I don't quite know yet, but will definitely be digging into this more. If i can get it ironed out i'd take out the HTTP driver to be honest -- not as elegant/easy to use!
|
|
||
| def _get_token(self) -> str: | ||
| """Get authentication token, refreshing if necessary""" | ||
| if self.token: |
There was a problem hiding this comment.
also im not sure token is ever unset even if it expires 🤔
No description provided.