From 69e8f8cff7f7e257ffdac3713a9d9051c4fd2c04 Mon Sep 17 00:00:00 2001 From: pmcneil Date: Wed, 16 Dec 2020 14:12:06 +1100 Subject: [PATCH 1/2] Fix limit on async suggestions so that it doesn't subtract the results before limiting. --- src/typeahead/dataset.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/typeahead/dataset.js b/src/typeahead/dataset.js index fce09c30..fad72144 100644 --- a/src/typeahead/dataset.js +++ b/src/typeahead/dataset.js @@ -269,9 +269,8 @@ var Dataset = (function() { // do not render the suggestions as they've become outdated if (!canceled && rendered < that.limit) { that.cancel = $.noop; - rendered += suggestions.length; that._append(query, suggestions.slice(0, that.limit - rendered)); - + rendered += suggestions.length; that.async && that.trigger('asyncReceived', query); } } From 589d5c87b0f9b5edee8d10ea76ee10ccc73ed8b9 Mon Sep 17 00:00:00 2001 From: pmcneil Date: Wed, 16 Dec 2020 14:21:22 +1100 Subject: [PATCH 2/2] Fix limit on async suggestions so that it doesn't subtract the results before limiting. --- src/typeahead/dataset.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/typeahead/dataset.js b/src/typeahead/dataset.js index fad72144..ce95055d 100644 --- a/src/typeahead/dataset.js +++ b/src/typeahead/dataset.js @@ -269,8 +269,9 @@ var Dataset = (function() { // do not render the suggestions as they've become outdated if (!canceled && rendered < that.limit) { that.cancel = $.noop; - that._append(query, suggestions.slice(0, that.limit - rendered)); - rendered += suggestions.length; + var appended = that.limit - rendered; + that._append(query, suggestions.slice(0, appended)); + rendered += appended; that.async && that.trigger('asyncReceived', query); } }