fix the script with subprocess

Author: kevinburkesegment

scripts/build_twilio_library.py

@@ -1,4 +1,5 @@
 import argparse
+import glob
 import json
 import os
 import re
@@ -83,7 +84,7 @@ def generate(spec_folder: str, spec_files: List[str], output_path: str, language
 
 
 def generate_domain_for_language(spec_file: str, config_path: str, spec_folder: str, output_path: str, language: str, parent_dir: str) -> None:
-    print("generate domain for language: {}, config: {}, spec file: {}".format(language, config_path, spec_file))
+    print("generate domain for language: {}, config: {}, spec folder: {}, file: {}".format(language, config_path, spec_folder, spec_file))
     full_path = os.path.join(spec_folder, spec_file)
     full_config_path = os.path.join(config_path, spec_file)
     config = {
@@ -96,21 +97,23 @@ def generate_domain_for_language(spec_file: str, config_path: str, spec_folder:
     }
     # print(config)
     with open(full_config_path, 'w') as f:
-        f.write(json.dumps(config))
+        f.write(json.dumps(config) + "\n")
 
 def run_openapi_generator(parent_dir: Path, language: str) -> None:
     properties = "-DapiTests=false"
     if language in {"node", "python"}:
         properties += " -DskipFormModel=false"
 
+    paths = glob.glob(os.path.join(CONFIG_FOLDER, language, "*"))
+
     command = [
         "java",
         *properties.split(),  # Splits e.g. "-DapiTests=false -DskipFormModel=false" into separate arguments
         "-cp",
         "target/twilio-openapi-generator.jar",
         "org.openapitools.codegen.OpenAPIGenerator",
         "batch",
-        f"{CONFIG_FOLDER}/{language}/*"
+        *paths,
     ]
 
     printable_cmd = " ".join(shlex.quote(arg) for arg in command)

scripts/generate_libraries/main.py

@@ -1,6 +1,11 @@
 #!/usr/bin/env python3
 
-# python -m scripts.generate_libraries.main --language go --input=./examples
+# an example way to run this script would be:
+#
+# cd /path/to/twilio-oai-generator
+# python -m scripts.generate_libraries.main --language go --input=../twilio-oai/spec/json --base=..
+#
+# and have twilio-oai and twilio-go as sibling directories to twilio-oai-generator
 
 import argparse
 import glob