Please reintroduce context.Context

[Azuka]

Issue Summary

This is a duplicate of #98 which has been closed with no update. context.Context support was introduced in https://github.com/twilio/twilio-go/blob/main/CHANGES.md#2022-11-10-version-120 then mysteriously reverted

Steps to Reproduce

N/A

Code Snippet

N/A

Exception/Log

N/A

Technical details:

• twilio-go version: 1.22.3
• go version: 1.22

[devnev]

Running into this issue as it also prevents tracing from working properly

[Hades32]

This is really pretty annoying. We are now creating a new client with this workaround:

// forceContextRoundTripper sets the given context on every request and passes it to the wrapped RoundTripper
type forceContextRoundTripper struct {
	roundTripper http.RoundTripper
	ctx          context.Context
}

func (f *forceContextRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
	req = req.Clone(f.ctx)
	return f.roundTripper.RoundTrip(req)
}

// NewClient creates a twilio client whose HTTP requests are bound by the passed context.
// This is required because their package doesn't expose the context param per operation...
func NewClient(ctx context.Context) *twilio.RestClient {
	c := twilio.NewRestClientWithParams(twilio.ClientParams{
		Username: env.TwilioAccountSid,
		Password: env.TwilioAuthToken,
	})
	httpClient := utils.NewHttpClient(5*time.Second, 100)
	httpClient.Transport = &forceContextRoundTripper{
		ctx:          ctx,
		roundTripper: httpClient.Transport,
	}
	c.RequestHandler.Client.(*twilioClient.Client).HTTPClient = httpClient
	return c
}

[tiwarishubham635]

Hi! We have added this request (DII-1926) to our internal backlog. +1/upvotes will help bring this up the priority. Thanks!

[devnev]

@Hades32 Nice, so you make a new client for every incoming request to associate the requests made by the client with the original request? Hacky but workable, thanks

[manisha1997]

We are actively working on this. We will try to release this as soon as possible