Skip to content

Commit e4d1452

Browse files
Avi MoondraAvi Moondra
authored andcommitted
fix tests
1 parent 1ba2002 commit e4d1452

File tree

3 files changed

+8
-20
lines changed

3 files changed

+8
-20
lines changed

charts/retool/ci/kubeconform-values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,3 +302,6 @@ extraManifests: []
302302
securityGroupPolicy:
303303
enabled: false
304304
groupIds: []
305+
306+
internalWorker:
307+
enabled: true

charts/retool/templates/_helpers.tpl

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -200,18 +200,3 @@ Set code executor service name
200200
{{- define "retool.codeExecutor.name" -}}
201201
{{ template "retool.fullname" . }}-code-executor
202202
{{- end -}}
203-
204-
205-
{{/*
206-
Set Worker enabled
207-
Usage: (include "retool.worker.enabled" .)
208-
*/}}
209-
{{- define "retool.worker.enabled" -}}
210-
{{- $output := "" -}}
211-
{{- if or (include "retool.workflows.enabled" .) (.Values.internalWorker.enabled) -}}
212-
{{- $output = "1" -}}
213-
{{- else -}}
214-
{{- $output = "" -}}
215-
{{- end -}}
216-
{{- $output -}}
217-
{{- end -}}
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
{{/* Compile all validation warnings into a single message and call fail. */}}
22
{{- define "retool.validationRules" -}}
33
{{- $messages := list -}}
4-
{{- $messages = append $messages (include "retool.validationRules.workers" .) -}}
4+
{{- $messages = append $messages (include "retool.validationRules.internalWorker" .) -}}
55
{{- $messages = without $messages "" -}}
66
{{- $message := join "\n" $messages -}}
77
{{- if $message -}}
88
{{- printf "\nVALUES VALIDATION:\n%s" $message | fail -}}
99
{{- end -}}
1010
{{- end -}}
1111

12-
{{- define "retool.validationRules.workers" -}}
13-
{{- if not (or (not (include "retool.worker.enabled" .)) (and (include "retool.worker.enabled" .) (include "retool.temporal.enabled" .))) -}}
14-
workers:
15-
Workers are enabled (via internalWorker.enabled, workflows.enabled explicitly, or workflows.enabled implicitly based on image.tag > 3.6.11), but Temporal is not enabled via retool-temporal-services-helm.enabled or workflows.temporal.enabled
12+
{{- define "retool.validationRules.internalWorker" -}}
13+
{{- if not (or (not (.Values.internalWorker.enabled)) (and (.Values.internalWorker.enabled) (or (include "retool.temporal.enabled" .) (include "retool.workflows.enabled" .)))) -}}
14+
internalWorker:
15+
Internal worker is enabled (via internalWorker.enabled), but Temporal is not enabled via retool-temporal-services-helm.enabled or workflows.temporal.enabled or via Retool's Managed Temporal for Retool Workflows (via workflows.enabled explicitly, or workflows.enabled implicitly based on image.tag > 3.6.11)
1616
{{- end -}}
1717
{{- end -}}

0 commit comments

Comments
 (0)