Apply suggestions from code review

Co-authored-by: Hendrik Ranocha <[email protected]>

Author: benegee

src/solvers/dgsem_tree/dg_2d.jl

@@ -367,8 +367,7 @@ function calc_volume_integral!(du, u,
 
             # Calculate FV volume integral contribution
             fv_kernel!(du, u, mesh, have_nonconservative_terms, equations,
-                       volume_flux_fv,
-                       dg, cache, element, alpha_element)
+                       volume_flux_fv, dg, cache, element, alpha_element)
         end
     end
 
@@ -439,8 +438,8 @@ end
 # - `fstar2_R::AbstractArray{<:Real, 3}`
 @inline function calcflux_fv!(fstar1_L, fstar1_R, fstar2_L, fstar2_R,
                               u::AbstractArray{<:Any, 4},
-                              mesh::TreeMesh{2}, have_nonconservative_terms::False,
-                              equations,
+                              mesh::TreeMesh{2},
+                              have_nonconservative_terms::False, equations,
                               volume_flux_fv, dg::DGSEM, element, cache)
     fstar1_L[:, 1, :] .= zero(eltype(fstar1_L))
     fstar1_L[:, nnodes(dg) + 1, :] .= zero(eltype(fstar1_L))
@@ -485,8 +484,8 @@ end
 # - `u_leftright::AbstractArray{<:Real, 4}`
 @inline function calcflux_fv!(fstar1_L, fstar1_R, fstar2_L, fstar2_R,
                               u::AbstractArray{<:Any, 4},
-                              mesh::TreeMesh{2}, have_nonconservative_terms::True,
-                              equations,
+                              mesh::TreeMesh{2},
+                              have_nonconservative_terms::True, equations,
                               volume_flux_fv, dg::DGSEM, element, cache)
     volume_flux, nonconservative_flux = volume_flux_fv
 

src/solvers/dgsem_tree/dg_3d.jl

@@ -429,8 +429,7 @@ function calc_volume_integral!(du, u,
 
             # Calculate FV volume integral contribution
             fv_kernel!(du, u, mesh, have_nonconservative_terms, equations,
-                       volume_flux_fv,
-                       dg, cache, element, alpha_element)
+                       volume_flux_fv, dg, cache, element, alpha_element)
         end
     end
 
@@ -472,9 +471,8 @@ end
     fstar3_R = fstar3_R_threaded[Threads.threadid()]
 
     calcflux_fv!(fstar1_L, fstar1_R, fstar2_L, fstar2_R, fstar3_L, fstar3_R, u,
-                 mesh, have_nonconservative_terms, equations, volume_flux_fv, dg,
-                 element,
-                 cache)
+                 mesh, have_nonconservative_terms, equations,
+                 volume_flux_fv, dg, element, cache)
 
     # Calculate FV volume integral contribution
     for k in eachnode(dg), j in eachnode(dg), i in eachnode(dg)
@@ -543,11 +541,11 @@ end
     return nothing
 end
 
-# Calculate the finite volume fluxes inside the elements (**without non-conservative terms**).
+# Calculate the finite volume fluxes inside the elements (**with non-conservative terms**).
 @inline function calcflux_fv!(fstar1_L, fstar1_R, fstar2_L, fstar2_R, fstar3_L,
                               fstar3_R, u,
-                              mesh::TreeMesh{3}, have_nonconservative_terms::True,
-                              equations,
+                              mesh::TreeMesh{3},
+                              have_nonconservative_terms::True, equations,
                               volume_flux_fv, dg::DGSEM, element, cache)
     volume_flux, nonconservative_flux = volume_flux_fv