Removed depricated code #3273
Open
Removed depricated code #3273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for only getting to this now. I currently have Translate Toolkit 2.4.0, and the existing code (with extractpoline) still works. Is it just deprecated, or was the removal reversed? Do we still need this? |
|
@friedelwolff If this PR is ok and gets merged, then we would be able to merge PR translate/translate#3596 in Translate Toolkit to get rid of this deprecated function. |
|
@friedelwolff Also check PR #3272 which kinda does the same thing as this one. |
|
The two functions are not equivalent: >>> from translate.storage import pypo
>>> pypo.extractpoline('"abc"')
'abc'
>>> pypo.unescape('"abc"')
'"abc"'What am I missing? |
|
You are right, they are not the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.