Merge #808: Clippy errors when running CI

5012351 CI: [#807] fixed more clippy errors (Mario)
040bc21 CI: [#807] using write to append string (Mario)
6540ada CI: [#807] removed unnecessary semicolons (Mario)

Pull request description:

  Fixes #807

ACKs for top commit:
  josecelano:
    ACK 5012351

Tree-SHA512: e3d6fc92d029bf8d8de7c10f5b768d117834eb92694bf25d6859e5f3a5c575d3501dff986e084889e3db17f474d56eee59621f608b004e27cb0e98e39ee6fa50

Author: josecelano

src/bin/create_test_torrent.rs

@@ -60,15 +60,13 @@ fn main() {
             // Attempt to create and write to the file
             let mut file = match File::create(&file_path) {
                 Ok(file) => file,
-                Err(e) => panic!("Failed to create file {file_path:?}: {e}"),
+                Err(e) => panic!("Failed to create file {}: {e}", file_path.display()),
             };
 
             if let Err(e) = file.write_all(&bytes) {
-                panic!("Failed to write to file {file_path:?}: {e}");
+                panic!("Failed to write to file {}: {e}", file_path.display());
             }
-
-            println!("File successfully written to {file_path:?}");
         }
         Err(e) => panic!("Error encoding torrent: {e}"),
-    };
+    }
 }

src/console/commands/seeder/app.rs

@@ -196,7 +196,7 @@ pub async fn run() -> anyhow::Result<()> {
                 info!(target:"seeder", "Uploaded torrent: {}", json.yellow());
             }
             Err(err) => print!("Error uploading torrent {err:?}"),
-        };
+        }
 
         if i != args.number_of_torrents {
             sleep(Duration::from_secs(args.interval));

src/mailer.rs

@@ -25,7 +25,7 @@ lazy_static! {
                 println!("Parsing error(s): {e}");
                 ::std::process::exit(1);
             }
-        };
+        }
 
         tera.autoescape_on(vec![".html", ".sql"]);
         tera.register_filter("do_nothing", do_nothing_filter);

src/services/torrent.rs

@@ -1,4 +1,5 @@
 //! Torrent service.
+use std::fmt::Write as _;
 use std::sync::Arc;
 
 use bittorrent_primitives::info_hash::InfoHash;
@@ -550,7 +551,7 @@ impl Index {
 
         // Add trackers from torrent file to magnet link
         for tracker in &torrent_response.trackers {
-            magnet.push_str(&format!("&tr={}", urlencoding::encode(tracker)));
+            let _ = write!(&mut magnet, "&tr={}", urlencoding::encode(tracker));
         }
 
         torrent_response.magnet_link = magnet;

src/services/user.rs

@@ -206,7 +206,7 @@ impl RegistrationService {
 
         if self.user_profile_repository.verify_email(&user_id).await.is_err() {
             return Err(ServiceError::DatabaseError);
-        };
+        }
 
         Ok(true)
     }

src/web/api/server/mod.rs

@@ -107,7 +107,7 @@ async fn start_server(
             .serve(router.into_make_service_with_connect_info::<std::net::SocketAddr>())
             .await
             .expect("API server should be running"),
-    };
+    }
 }
 
 #[derive(Error, Debug)]

src/web/api/server/v1/contexts/torrent/handlers.rs

@@ -336,28 +336,28 @@ async fn build_add_torrent_request_from_payload(mut payload: Multipart) -> Resul
                 let data = field.bytes().await.unwrap();
                 if data.is_empty() {
                     continue;
-                };
+                }
                 title = String::from_utf8(data.to_vec()).map_err(|_| errors::Request::TitleIsNotValidUtf8)?;
             }
             "description" => {
                 let data = field.bytes().await.unwrap();
                 if data.is_empty() {
                     continue;
-                };
+                }
                 description = String::from_utf8(data.to_vec()).map_err(|_| errors::Request::DescriptionIsNotValidUtf8)?;
             }
             "category" => {
                 let data = field.bytes().await.unwrap();
                 if data.is_empty() {
                     continue;
-                };
+                }
                 category = String::from_utf8(data.to_vec()).map_err(|_| errors::Request::CategoryIsNotValidUtf8)?;
             }
             "tags" => {
                 let data = field.bytes().await.unwrap();
                 if data.is_empty() {
                     continue;
-                };
+                }
                 let string_data = String::from_utf8(data.to_vec()).map_err(|_| errors::Request::TagsArrayIsNotValidUtf8)?;
                 tags = serde_json::from_str(&string_data).map_err(|_| errors::Request::TagsArrayIsNotValidJson)?;
             }

tests/e2e/environment.rs

@@ -84,7 +84,7 @@ impl TestEnv {
     pub fn provides_a_private_tracker(&self) -> bool {
         if !self.is_shared() {
             return false;
-        };
+        }
 
         match self.server_settings() {
             Some(settings) => settings.tracker.private,
@@ -148,11 +148,7 @@ impl TestEnv {
             State::RunningShared => {
                 let connect_url_env_var = ENV_VAR_DB_CONNECT_URL;
 
-                if let Ok(connect_url) = env::var(connect_url_env_var) {
-                    Some(connect_url)
-                } else {
-                    None
-                }
+                env::var(connect_url_env_var).ok()
             }
             State::RunningIsolated => internal_connect_url,
             State::Stopped => None,